1. 26 Mar, 2020 6 commits
  2. 25 Mar, 2020 1 commit
  3. 20 Mar, 2020 1 commit
  4. 19 Mar, 2020 1 commit
  5. 17 Mar, 2020 1 commit
    • Tanu Kaskinen's avatar
      ucm: Don't log errors during normal operation · 9d36210b
      Tanu Kaskinen authored
      It's completely normal to not have explicit channel configuration for
      stereo devices. In fact, the ALSA developers actively avoid configuring
      the channels for stereo devices.
      
      I also dropped the word "duplex" from the messages, because "stereo
      duplex" implies bidirectionality, but most devices use one direction
      only.
      9d36210b
  6. 11 Mar, 2020 1 commit
    • Philip Withnall's avatar
      daemon: Add --log-target=journal to pulseaudio.service · 60531aef
      Philip Withnall authored
      When running under systemd from its `.service` file, the daemon is
      started with `--daemonize=no`. This means that the default logging
      target is `stderr` (see the documentation for `--log-target` in
      `pulse-daemon.conf(5)`). That works fine, but results in all the
      structured logging data from the `pa_log()` calls being thrown away and
      not making it into the journal.
      
      In order to preserve structured logging data, and hence make the
      messages in the journal a little more useful (for example, allowing the
      user to filter by message priority), explicitly pass
      `--log-target=journal` in the `.service` file. This should always be
      appropriate because the journal should always be used with systemd.
      Signed-off-by: Philip Withnall's avatarPhilip Withnall <withnall@endlessm.com>
      60531aef
  7. 07 Mar, 2020 2 commits
    • Arun Raghavan's avatar
      ci: Go back to using CI templates from master · 94e479b2
      Arun Raghavan authored
      Consensus is that we prefer this to potentially remaining on older,
      commits and manually updating at unknown frequency.
      94e479b2
    • Arun Raghavan's avatar
      ci: Update for changes in CI template · 04bf85cb
      Arun Raghavan authored
      This updates things based on changes in the templates that we use. Also
      pins the ref in the template repo so that our build does not break when
      the template parameters change.
      
      This does mean that we should likely periodically check the ci-templates
      repo, but this seems to be better than the build breaking unexpectedly.
      04bf85cb
  8. 05 Mar, 2020 1 commit
    • Khem Raj's avatar
      remap/arm: Adjust inline asm constraints · 3450d1fc
      Khem Raj authored
      gcc10 can effectively emit single precision registers if right
      operand modifier constraint is not in use
      
      This results in assembler rejecting the code
      
      /tmp/ccEG4QpI.s:646: Error: VFP/Neon double precision register expected -- `vtbl.8 d3,{d0,d1},s8'
      /tmp/ccEG4QpI.s:678: Error: invalid instruction shape -- `vmul.f32 d0,d0,s8'
      
      Therefore add %P qualifier to request double registers sinece 'w' could
      mean variable could be stored in s0..s14 and GCC defaults to printing out s0..s14.
      Note those registers map to d0..d7 also.
      
      Output generated is exactly same with gcc9, and it also now compiles
      with gcc10
      
      Its not documented well in gcc docs and there is a ticket for that
      https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84343Signed-off-by: Khem Raj's avatarKhem Raj <raj.khem@gmail.com>
      3450d1fc
  9. 01 Mar, 2020 1 commit
  10. 27 Feb, 2020 1 commit
  11. 20 Feb, 2020 1 commit
  12. 15 Feb, 2020 1 commit
  13. 14 Feb, 2020 2 commits
  14. 05 Feb, 2020 1 commit
  15. 03 Feb, 2020 1 commit
    • Georg Chini's avatar
      sink, source: Fix stream rescue from sinks or sources without port · bdc6b6ff
      Georg Chini authored
      Currently pa_{sink,source}_move_streams_to_default_{sink,source}() check the
      availability of the old sink or source. The sink or source is only marked as
      unavailable if the active port of a sink or source is not available.
      Therefore sinks or sources without port are always considered available,
      even if they are in the process of being unlinked and streams are not
      rescued.
      
      This patch removes the availability check because it is unnecessary. The
      functions are only called if the sink or source becomes unavailable or if
      the default sink or source changes, therefore the default_sink_changed or
      default_source_changed argument can be used as an indicator if the old
      sink or source is still present. In the case that the old default sink or
      source becomes unavailable, the function will be called twice, once when
      the default sink or source changes and once when the old sink or source
      is unlinked.
      bdc6b6ff
  16. 30 Jan, 2020 2 commits
  17. 23 Jan, 2020 1 commit
    • Georg Chini's avatar
      daemon.conf: Add boolean rescue_streams parameter · b72f2955
      Georg Chini authored
      Since merge requests
      
      !209 and
      !216
      
      the rescuing of streams could no longer be disabled. This patch adds a boolean
      parameter rescue-streams to daemon.conf which allows to disable rescuing.
      
      The parameter defaults to true (rescuing enabled).
      b72f2955
  18. 20 Jan, 2020 1 commit
    • Nick Moriarty's avatar
      Permit root-owned home directory · 97d0eda2
      Nick Moriarty authored
      On certain types of filesystem (especially NFS appliances which support
      multiple operating systems), the user's home directory may report as
      being owned by root rather than the user, yet still permit the user to
      create and modify files normally (which will be owned by them).
      
      Our users have home directories hosted on a NetApp storage appliance
      which uses mixed-mode ACLs but where the home directory is set up with
      NTFS ACLs at the top level.  This means they have the expected effective
      permissions, but the ownership reports as root.  This could also be the
      case if the filesystem were using NFS4 ACLs or similar.
      97d0eda2
  19. 16 Jan, 2020 2 commits
  20. 13 Jan, 2020 1 commit
    • Georg Chini's avatar
      virtual sources: Propagate asyncmsgq change after source-output move · 051f7508
      Georg Chini authored
      Currently, when the master of a virtual source is moved, the change of the
      asyncmsgq is not propagated to other attached virtual sources. This leads
      to a crash when the original master source is no longer available.
      
      This patch fixes the issue by modifying the moving callback to propagate the
      change to attached virtual sources.
      
      Virtual sinks show a similar bug but that will be fixed in a different patch
      series.
      051f7508
  21. 05 Jan, 2020 1 commit
  22. 04 Jan, 2020 1 commit
    • Tanu Kaskinen's avatar
      virtual-source: Don't process the rewind during requesting it · a71136be
      Tanu Kaskinen authored
      The request_rewind() callback of the uplink sink called
      pa_sink_process_rewind(), which is not allowed. Things are supposed to
      happen so that first a rewind is requested, and then during the next
      rtpoll loop the sink will process the request. Calling
      pa_sink_process_rewind() during the request phase caused a crash.
      
      Having a request_rewind() callback is completely unnecessary, because
      it's only useful for forwarding the request to a downstream sink. In
      this case there is no downstream sink.
      
      I also set max_rewind to 0, because the sink doesn't support rewinding.
      
      Fixes: #775
      a71136be
  23. 02 Jan, 2020 4 commits
    • Ben Buchwald's avatar
      module-jackdbus-detect: Separate sink/source channels arguments · bcc2162f
      Ben Buchwald authored
      If a channels argument is passed module-jackdbus-detect, it is passed to both
      module-jack-sink and module-jack-source when those are started. This is a
      problem if you want a different number of input channels from output channels.
      In particular, if you want more of one than you physically have of the other,
      it will fail. This commit adds separate source_channels and sink_channels
      arguments to be able to specify the channels arguments to module-jack-source
      and module-jack-sink separately. The combined channels argument is kept for
      backwards compatibility and will be used as a default for source_channels and
      sink_channels if either of them is omitted.
      bcc2162f
    • Ben Buchwald's avatar
      module-jackdbus-detect: Allow omitting channels argument · 64211b8f
      Ben Buchwald authored
      module-jackdbus-detect documents the channels argument as optional and "if
      omitted, the sink wil use the number of physical output port and the source
      will use the number of physical input ports registered in the JACK server."
      However, although it would correctly omit the channels argument to
      module-jack-sink and module-jack-source if its channel argument was omitted,
      its argument validation was broken to consider omitting channels an error.
      This commit properly validates the channels argument so omitting it is
      accepted.
      64211b8f
    • pali's avatar
      de666447
    • pali's avatar
      3f13af50
  24. 27 Dec, 2019 2 commits
    • Tanu Kaskinen's avatar
      switch-on-connect: Blacklist HDMI devices by default · cdcb0188
      Tanu Kaskinen authored
      As the comment says, switching to HDMI automatically often causes
      problems. Commit bae8c16b
      ("switch-on-connect: Do not ignore HDMI sinks") enabled switching to
      HDMI earlier. It was known already then that HDMI monitors don't
      necessarily have speakers on them, but I accepted the patch on the
      basis that module-switch-on-connect acts only if the card profile is
      switched to HDMI, so if switching to HDMI is wrong, then already the
      profile switch should cause problems. I didn't think of the case where
      the default sink is on some other card, in which case switching the
      profile on the HDMI card doesn't cause problems by itself.
      
      I don't want to revert bae8c16b, because João needs to be able to
      configure their systems to automatically switch to HDMI. Instead, this
      patch utilizes the new blacklisting feature in module-switch-on-connect
      to blacklist HDMI sinks by default. Switching to HDMI can be enabled by
      setting the blacklist modarg to an empty string or something that
      doesn't match HDMI sinks.
      
      Fixes: #749
      cdcb0188
    • Tanu Kaskinen's avatar
      core-util: Handle zero-length volume string · 4dba56c1
      Tanu Kaskinen authored
      Without checking for zero we end up accessing memory outside the str
      buffer: str[len - 1].
      
      Fixes: #768
      4dba56c1
  25. 23 Dec, 2019 3 commits