1. 23 Jan, 2020 1 commit
    • Georg Chini's avatar
      daemon.conf: Add boolean rescue_streams parameter · b72f2955
      Georg Chini authored
      Since merge requests
      !209 and
      the rescuing of streams could no longer be disabled. This patch adds a boolean
      parameter rescue-streams to daemon.conf which allows to disable rescuing.
      The parameter defaults to true (rescuing enabled).
  2. 20 Jan, 2020 1 commit
    • Nick Moriarty's avatar
      Permit root-owned home directory · 97d0eda2
      Nick Moriarty authored
      On certain types of filesystem (especially NFS appliances which support
      multiple operating systems), the user's home directory may report as
      being owned by root rather than the user, yet still permit the user to
      create and modify files normally (which will be owned by them).
      Our users have home directories hosted on a NetApp storage appliance
      which uses mixed-mode ACLs but where the home directory is set up with
      NTFS ACLs at the top level.  This means they have the expected effective
      permissions, but the ownership reports as root.  This could also be the
      case if the filesystem were using NFS4 ACLs or similar.
  3. 16 Jan, 2020 2 commits
  4. 13 Jan, 2020 1 commit
    • Georg Chini's avatar
      virtual sources: Propagate asyncmsgq change after source-output move · 051f7508
      Georg Chini authored
      Currently, when the master of a virtual source is moved, the change of the
      asyncmsgq is not propagated to other attached virtual sources. This leads
      to a crash when the original master source is no longer available.
      This patch fixes the issue by modifying the moving callback to propagate the
      change to attached virtual sources.
      Virtual sinks show a similar bug but that will be fixed in a different patch
  5. 05 Jan, 2020 1 commit
  6. 04 Jan, 2020 1 commit
    • Tanu Kaskinen's avatar
      virtual-source: Don't process the rewind during requesting it · a71136be
      Tanu Kaskinen authored
      The request_rewind() callback of the uplink sink called
      pa_sink_process_rewind(), which is not allowed. Things are supposed to
      happen so that first a rewind is requested, and then during the next
      rtpoll loop the sink will process the request. Calling
      pa_sink_process_rewind() during the request phase caused a crash.
      Having a request_rewind() callback is completely unnecessary, because
      it's only useful for forwarding the request to a downstream sink. In
      this case there is no downstream sink.
      I also set max_rewind to 0, because the sink doesn't support rewinding.
      Fixes: #775
  7. 02 Jan, 2020 4 commits
    • Ben Buchwald's avatar
      module-jackdbus-detect: Separate sink/source channels arguments · bcc2162f
      Ben Buchwald authored
      If a channels argument is passed module-jackdbus-detect, it is passed to both
      module-jack-sink and module-jack-source when those are started. This is a
      problem if you want a different number of input channels from output channels.
      In particular, if you want more of one than you physically have of the other,
      it will fail. This commit adds separate source_channels and sink_channels
      arguments to be able to specify the channels arguments to module-jack-source
      and module-jack-sink separately. The combined channels argument is kept for
      backwards compatibility and will be used as a default for source_channels and
      sink_channels if either of them is omitted.
    • Ben Buchwald's avatar
      module-jackdbus-detect: Allow omitting channels argument · 64211b8f
      Ben Buchwald authored
      module-jackdbus-detect documents the channels argument as optional and "if
      omitted, the sink wil use the number of physical output port and the source
      will use the number of physical input ports registered in the JACK server."
      However, although it would correctly omit the channels argument to
      module-jack-sink and module-jack-source if its channel argument was omitted,
      its argument validation was broken to consider omitting channels an error.
      This commit properly validates the channels argument so omitting it is
    • pali's avatar
    • pali's avatar
  8. 27 Dec, 2019 2 commits
    • Tanu Kaskinen's avatar
      switch-on-connect: Blacklist HDMI devices by default · cdcb0188
      Tanu Kaskinen authored
      As the comment says, switching to HDMI automatically often causes
      problems. Commit bae8c16b
      ("switch-on-connect: Do not ignore HDMI sinks") enabled switching to
      HDMI earlier. It was known already then that HDMI monitors don't
      necessarily have speakers on them, but I accepted the patch on the
      basis that module-switch-on-connect acts only if the card profile is
      switched to HDMI, so if switching to HDMI is wrong, then already the
      profile switch should cause problems. I didn't think of the case where
      the default sink is on some other card, in which case switching the
      profile on the HDMI card doesn't cause problems by itself.
      I don't want to revert bae8c16b, because João needs to be able to
      configure their systems to automatically switch to HDMI. Instead, this
      patch utilizes the new blacklisting feature in module-switch-on-connect
      to blacklist HDMI sinks by default. Switching to HDMI can be enabled by
      setting the blacklist modarg to an empty string or something that
      doesn't match HDMI sinks.
      Fixes: #749
    • Tanu Kaskinen's avatar
      core-util: Handle zero-length volume string · 4dba56c1
      Tanu Kaskinen authored
      Without checking for zero we end up accessing memory outside the str
      buffer: str[len - 1].
      Fixes: #768
  9. 23 Dec, 2019 7 commits
  10. 22 Dec, 2019 5 commits
  11. 21 Dec, 2019 4 commits
  12. 20 Dec, 2019 2 commits
  13. 18 Dec, 2019 7 commits
  14. 14 Dec, 2019 2 commits
    • Hui Wang's avatar
      stream-restore: skip entries set on source from gnome-control-center · f62a49b8
      Hui Wang authored
      When users select an input device from gnome-control-center UI, the
      source of this input device will be set to the
      configured_default_source and the default_source, these actions are
      expected, but after these actions, the gnome-control-center will call
      extension_cb() to modify the entries in the database, let all stream
      entries to bind the source users select, this is not correct since the
      source is default_source now.
      This is a temp fix for this issue, after gnome-control-center fixes
      this problem, this patch should be reverted.
      Signed-off-by: Hui Wang's avatarHui Wang <hui.wang@canonical.com>
    • Hui Wang's avatar
      source: move the streams to the default_source when the source unlink · 5e0d5a86
      Hui Wang authored
      When a source is unlinked, all streams of this source are moved to
      default_source, this action is implemented in the core rather than
      modules now.
      And after this change, the module-rescue-streams is not needed, but
      for backward compatibility, we keep it as a dummy module.
      Signed-off-by: Hui Wang's avatarHui Wang <hui.wang@canonical.com>