Skip XRef reconstruction for new-style XRef streams (!70) · Merge requests · poppler / poppler

Tobias Deiminger requested to merge haxtibal/poppler:skip-constructxref-if-xrefstream into master Oct 01, 2018

XRef::constructXRef was invented to support old style XRef tables. Sadly it won't work for new style XRef streams. If applied anyway, it corrupts our existing XRef::entries array. Better skip reconstruction for the XRef-stream-case in XRef::readXRefUntil (just like XRef::fetch already does).

Fixes #139 (closed) and Okular bug 395660. There had been multiple patch variants. Follow discussion in #139 (closed) to see why the approach presented here is probably the best.

Long term goal should be to implement a XRef::constructXRef variant that can cope with XRef streams.

Skip XRef reconstruction for new-style XRef streams

Merge request reports