Skip to content

Splash: Restrict filling of overlapping boxes

Marek Kasik requested to merge mkasik/poppler:750-heap-buffer-overflow-in-Splash-blitTransparent into master

This commit fixes the issue #750 (closed) which is caused by reading of pixels outside of area of source bitmap when processing 2 overlapping areas in Splash::blitTransparent(). It checks whether area to process does not run out of allocated memory for source and for destination and shrink it if needed.

However, it does not fixes "Conditional jump or move depends on uninitialised value(s)" in subsequent Splash::composite(). The values are not really initialized.

Closes #750 (closed)

Merge request reports