evince and selection on rotated text

Submitted by Pedro Villavicencio

Assigned to poppler-bugs

Link to original bug (#16619)

Description

this report has been filed here:

https://bugs.edge.launchpad.net/ubuntu/+source/poppler/+bug/245620

"When selecting rotated text in evince, it doesn't work correctly (see attached screenshot)."

http://launchpadlibrarian.net/15829551/Capture-1.png http://launchpadlibrarian.net/15829586/m1.pdf

Thanks,

Marek Kasik @mkasik submitted a patch:

Attached is a patch which improves selection of words when PDF is rotated by multiples of 90°. It sets correct bounds on various visit*() functions.

The patch doesn't solve all problems related to this. There are still problems with order of selected lines and blocks when multiple blocks are selected.

The problem with correct order of lines is easier to fix but I have not a patch ready yet. The problem with correct order of blocks is a little bit harder since it needs to correct flows.

The main problem why I started to look into this was that poppler shows this warning on some PDFs (see next attachment):

*** BUG *** In pixman_region32_init_rect: Invalid rectangle passed Set a breakpoint on '_pixman_log_error' to debug

Btw, the patch doesn't fix the problem shown on the Pedro's screenshot but it is related to the name of this bug.

Patch 92928, "Respect orientation when selecting words":
0001-TextOutputDev-Respect-orientation-when-selecting-wor.patch

Marek Kasik @mkasik uploaded an attachment:

Attachment 92929, "reproducer showing "Invalid rectangle" error when selecting text":
reproducer.pdf

Christopher M. Penalver said:

Problem confirmed:

1. lsb_release -rd Description: Ubuntu Vivid Vervet (development branch) Release: 15.04

2. libpoppler 0.28.1-1ubuntu1

apt-cache policy evince evince: Installed: 3.14.1-0ubuntu1 Candidate: 3.14.1-0ubuntu1 Version table: *** 3.14.1-0ubuntu1 0 500 http://us.archive.ubuntu.com/ubuntu/ vivid/main amd64 Packages 100 /var/lib/dpkg/status

3. What is expected to happen via the attached document is that one may highlight the text that has been rotated at a 45 degree angle, one row at a time, just like Adobe Reader 10.x: https://bugs.launchpad.net/ubuntu/+source/poppler/+bug/245620/+attachment/314937/+files/m1.pdf

4. What happens instead is it highlights parts of the line, along with others, as per the attached screenshot: https://bugs.launchpad.net/ubuntu/+source/poppler/+bug/245620/+attachment/314936/+files/Capture-1.png

Still an issue as of evince 3.38.2, poppler 20.09

Hi, I'll prepare a MR for this.

Hi, I've prepared a merge request for my patch from the original bug. It fixes the issue when you want to select text rotated by multiples of 90 degrees (not an arbitrary angle).

See mkasik/poppler!1 (closed)

Why have you made the MR against your repo and not against this?

It happened by mistake. I've created a new merge request for that - !949 (merged).

mentioned in merge request !949 (merged)

mentioned in commit vorlon/poppler@a4e927b9