Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • P poppler
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 656
    • Issues 656
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 42
    • Merge requests 42
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • poppler
  • poppler
  • Merge requests
  • !735

Open
Created Dec 18, 2020 by Jon Howell@jonh
  • Report abuse
Report abuse

Draft:Plotler - HPGL output for pen plotters, engravers, laser projectors

  • Overview 49
  • Commits 9
  • Pipelines 18
  • Changes 37

Hi Poppler crew,

In this request:

  • the first two commits refactor poppler/SplashOutputDev to enable code sharing with the proposed new output device, and expose a couple interfaces in splash as public.
  • the third commit adds the new code for utils/plotler, the utility that adds the new stroke-output mode.

Things I know need attention:

  • The third commit adds some PDFs that I test (manually) with. They don't go here. Can I get guidance on where they belong?
  • See Plot.h:136 for a comment/review request about a new matrix type.
  • There are no tests introduced. I'd like guidance on what would be appropriate here. Unit tests? How do you do stable end-to-end tests for graphical output?

Thanks for your advice!

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: plotler-new