Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
P
poppler
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 613
    • Issues 613
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 40
    • Merge Requests 40
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • poppler
  • poppler
  • Merge Requests
  • !70

Closed
Opened Oct 01, 2018 by Tobias Deiminger@haxtibalGuest
  • Report abuse
Report abuse

Skip XRef reconstruction for new-style XRef streams

  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

XRef::constructXRef was invented to support old style XRef tables. Sadly it won't work for new style XRef streams. If applied anyway, it corrupts our existing XRef::entries array. Better skip reconstruction for the XRef-stream-case in XRef::readXRefUntil (just like XRef::fetch already does).

Fixes #139 (closed) and Okular bug 395660. There had been multiple patch variants. Follow discussion in #139 (closed) to see why the approach presented here is probably the best.

Long term goal should be to implement a XRef::constructXRef variant that can cope with XRef streams.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: poppler/poppler!70
Source branch: skip-constructxref-if-xrefstream