Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
P
poppler
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 611
    • Issues 611
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 39
    • Merge Requests 39
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • poppler
  • poppler
  • Merge Requests
  • !684

Closed
Opened Nov 14, 2020 by Tobias Deiminger@haxtibalGuest
  • Report abuse
Report abuse

WIP: Fix wrong clipping when rendering curves in Splash

  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 1

Splash::strokeNarrow may detect clipping of y1 at yMaxI, even if it shouldn't clip because y1 and yMaxI actually stem from the same double precision y path value.

That's because y1 is calculated as (int)floor(y), while yMaxI is calculated as (int)ceil(y) - 1 in SplashClip::clipToRect. Results are sometimes different, depending on the exact double precision value.

When doing the clipping, x1 may get overly increased, leading to a too long span in x-direction. The high increment is likely an unrelated second issue, which I did not investigate here.

Fixes #990 (closed), because it avoids the "too much increment" situation in first place.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: poppler/poppler!684
Source branch: bugfix/990_path_clipping