Skip to content

Cleanup displayprofile initialization

Philipp Knechtges requested to merge d1saster/poppler:cleanup_displayprofile_init into master

This is a set of 4 patches that builds up on the two patches in merge request !558 (merged).

  • The first two patches in this merge request are concerned with moving the postscript CSA generation from GfxColorTransform to GfxICCBasedColorSpace, which became possible by ref-counting the profiles (cf. !558 (merged)). Since this makes storing the profiles in GfxColorTransform superfluous, this code has been removed again.
  • The third patch is the main patch in the merge request that completely removes the setting of display profiles from GfxColorTransform. There has already been code in place in GfxState, which now takes over more responsibility. Furthermore, the default route to set a display profile is now through the OutputDev class.
  • The last commit just fixes one occurrence of an GfxColorSpace::parse call without a proper GfxState initialization.

In principle, all these patches should be no user-visible changes, unless one makes use of the code path in the former GfxColorSpace::setupColorProfiles that load either "diplay.icc" or "RGB.icc".

Merge request reports