Skip to content

Remove fallback font list in commit b6a783b3

Nelson Benítez León requested to merge nbenitez/poppler:refactor_fallbackfont into master

There's no need to use a static list of fonts to resolve the Helv font name created by Firefox pdf.js when adding a FreeText annot.

We were just not looking for it in the appropiate place.

That font is in the Resources dictionary of the annotation's default (N) appearance stream (AP) i.e. annot -> AP -> N -> Resources -> Font -> Helv see output from https://pdf.hyzyla.dev/

So this commit removes the fallback font static list and instead improves our font search logic.

Also fixes a small leak of font_desc->font_name not being freed before assigning to it with g_strdup().

Improves !1595 (merged)

Edited by Nelson Benítez León

Merge request reports