GitLab

Submitted by fre..@..et.com

Assigned to poppler-bugs

Link to original bug (#104861)

Description

Adding 0.5 to a double before formatting with "%5.0f" results in a rounding error. Presumably it was originally done before truncating to int.

--- utils/ImageOutputDev.cc.old 2018-01-30 16:38:42.179170000 +0200 +++ utils/ImageOutputDev.cc 2018-01-30 16:39:13.506750000 +0200 @@ -234,13 +234,13 @@ double *mat = state->getCTM(); double width2 = mat[0] + mat[2]; double height2 = mat[1] + mat[3];

• double xppi = fabs(width*72.0/width2) + 0.5;
• double yppi = fabs(height*72.0/height2) + 0.5;

• double xppi = fabs(width*72.0/width2);
• double yppi = fabs(height*72.0/height2); if (xppi < 1.0) printf("%5.3f ", xppi); else printf("%5.0f ", xppi); if (yppi < 1.0) printf("%5.3f ", yppi); else printf("%5.0f ", yppi);