1. 20 Jan, 2022 3 commits
    • Albert Astals Cid's avatar
      Revert e2ec957c · d70e614b
      Albert Astals Cid authored
      Until we depend on a newer gcc (>= 9.1)
      
      We still support gcc 8 and it seems it's not super obvious to use it
      there, might need linking to an extra library in some platforms,
      and honestly for the 1 warning on MSVC that this fixes
      it's not worth the effort to figure out how to link to that lib
      
      See Issue 1203 for more info.
      d70e614b
    • Albert Astals Cid's avatar
      Fix glib compilation on MSVC · 4d2fa980
      Albert Astals Cid authored and Albert Astals Cid's avatar Albert Astals Cid committed
      glib-mkenums is a python script and you can't tell Windows to run those,
      so tell windows to run python with glib-mkenums as script to run
      4d2fa980
    • Albert Astals Cid's avatar
      pdfsig: Fix compile with MSVC · 14baf977
      Albert Astals Cid authored
      14baf977
  2. 18 Jan, 2022 1 commit
    • Albert Astals Cid's avatar
      SignatureHandler: Fix crashes on Windows · 79984852
      Albert Astals Cid authored and Albert Astals Cid's avatar Albert Astals Cid committed
      We should not use SEC_ASN1_XTRN since on Windows that means
      SEC_ASN1_DYNAMIC which means the third parameter is a function.
      
      IssuerSerialTemplate is not a function
      
      SECOID_AlgorithmIDTemplate was a function, but that was also a mistake
      since it's defined as a template in secoid.h
      79984852
  3. 17 Jan, 2022 4 commits
  4. 16 Jan, 2022 1 commit
    • Nelson Benítez León's avatar
      glib: try with utf8 password if latin1 fails · 90d1dd7b
      Nelson Benítez León authored and Albert Astals Cid's avatar Albert Astals Cid committed
      when opening encrypted files in below functions.
      
      poppler_document_new_from_file():
      poppler_document_new_from_data():
      poppler_document_new_from_bytes():
      poppler_document_new_from_stream():
      poppler_document_new_from_fd():
      
      Poppler-glib converts password to latin1 before opening,
      but as shown in issue #824 there could be files encrypted
      with a UTF8 password, and other pdf viewers handle this
      well, so let's do the same and try with UTF-8 if latin1
      fails. Note: we originally receive the password in UTF-8
      from GTK.
      
      Thanks @aacid for clue about how this was fixed in Okular side.
      
      Fixes issue #824
      90d1dd7b
  5. 13 Jan, 2022 1 commit
  6. 12 Jan, 2022 2 commits
  7. 10 Jan, 2022 2 commits
  8. 07 Jan, 2022 1 commit
  9. 05 Jan, 2022 10 commits
  10. 04 Jan, 2022 1 commit
  11. 03 Jan, 2022 2 commits
  12. 29 Dec, 2021 2 commits
  13. 15 Dec, 2021 1 commit
  14. 14 Dec, 2021 2 commits
  15. 12 Dec, 2021 2 commits
  16. 10 Dec, 2021 1 commit
  17. 08 Dec, 2021 1 commit
  18. 07 Dec, 2021 3 commits
    • Albert Astals Cid's avatar
      Remove Object::takeString · fd5c4037
      Albert Astals Cid authored
      it's a micro optimization used in non-hot paths and is not even correct
      due to how GooStrings inside Objects are shared, so just kill it and
      copy a few strings in those non-hot paths
      fd5c4037
    • Nelson Benítez León's avatar
      TextOutputDev: require more spacing between columns · f20d9e5f
      Nelson Benítez León authored and Albert Astals Cid's avatar Albert Astals Cid committed
      Require more spacing for adjacent text to be
      considered a separate column of text.
      
      We do that by increasing 'minColSpacing1' parameter,
      which marks the distance, within which, an adjacent
      word will be pulled to the current block.
      
      We provide a way to tweak the default value:
      double getMinColSpacing1();
      void setMinColSpacing1(double val);
      
      Fixes issue #1093
      f20d9e5f
    • Christian Persch's avatar
      glib: Plug some mem leaks · ccfeabf5
      Christian Persch authored and Albert Astals Cid's avatar Albert Astals Cid committed
      This code leaked a GooString each time it was called.
      
      ==1018012== 56 (32 direct, 24 indirect) bytes in 1 blocks are definitely lost in loss record 11,042 of 19,178
      ==1018012==    at 0x4841FF5: operator new(unsigned long) (vg_replace_malloc.c:422)
      ==1018012==    by 0x1EFE8DA5: copy (GooString.h:104)
      ==1018012==    by 0x1EFE8DA5: Object::copy() const (Object.cc:52)
      ==1018012==    by 0x1EFE8EE8: Object::fetch(XRef*, int) const (Object.cc:78)
      ==1018012==    by 0x1EF6C0C7: Dict::lookup(char const*, int) const (Dict.cc:167)
      ==1018012==    by 0x1EFF5592: dictLookup (Object.h:622)
      ==1018012==    by 0x1EFF5592: PDFDoc::getDocInfoStringEntry(char const*) (PDFDoc.cc:779)
      ==1018012==    by 0x1EA00E71: getDocInfoCreatDate (PDFDoc.h:277)
      ==1018012==    by 0x1EA00E71: poppler_document_get_creation_date_time (poppler-document.cc:1596)
      ccfeabf5