1. 21 Mar, 2019 1 commit
  2. 16 Mar, 2019 1 commit
  3. 28 Feb, 2019 1 commit
  4. 20 Dec, 2018 1 commit
  5. 06 Dec, 2018 1 commit
  6. 15 Nov, 2018 1 commit
  7. 14 Nov, 2018 1 commit
  8. 11 Nov, 2018 1 commit
  9. 23 Oct, 2018 1 commit
  10. 21 Oct, 2018 2 commits
  11. 10 Oct, 2018 1 commit
    • Adam Reichold's avatar
      Remove usage of pragmas interface and implementation · 7f20ace4
      Adam Reichold authored
      GCC recommends not using them for a long time and its documentation says:
      > These #pragmas have been superceded as of GCC 2.7.2 by COMDAT support
      > and the “key method” heuristic mentioned in Vague Linkage.
      > Using them can actually cause your program to grow due to
      > unnecessary out-of-line copies of inline functions.
      
      Also nobody seems to set USE_GCC_PRAGMAS and sometimes they were
      guarded by just __GNUC__ which upsets Clang.
      7f20ace4
  12. 08 Oct, 2018 5 commits
  13. 02 Oct, 2018 1 commit
  14. 27 Sep, 2018 1 commit
    • Oliver Sander's avatar
      FreeText: Use font from default appearance string · f3e3dd80
      Oliver Sander authored and Albert Astals Cid's avatar Albert Astals Cid committed
      If a FreeText annotation misses an AP entry, try to create a temporary font
      as defined by its default appearance string. Tf operator names the font resource,
      and we can search for the resource inside the default resource dictionary.
      See ISO32000 sections about "Free Text Annotations" and "Variable Text".
      
      If lookup fails for some reason, use Helvetica as fallback.
      
      Patch done together with Tobias Deiminger
      f3e3dd80
  15. 21 Sep, 2018 2 commits
  16. 02 Sep, 2018 4 commits
    • Albert Astals Cid's avatar
      Add missing (C) · 042d2483
      Albert Astals Cid authored
      And minor style change by Albert
      042d2483
    • Tobias Deiminger's avatar
      More review fixes · d4b4be23
      Tobias Deiminger authored and Albert Astals Cid's avatar Albert Astals Cid committed
      Text color is indicated by nonstroking color in graphics state
      	Assumption: Text rendering mode is 'fill'.
      
      Increase color precision for lossless roundtrip of 16 bit integers
      	Our API takes QColor from user. We want to support a lossless roundtrip
      	of QColor (16 bit per channel internally) through document save and
      	load, and empirically found .5f is best match.
      
      Check only .5f case of color channel roundtrip. Include 65535.
      	We check if precision == 5 is sufficient, and fail if not. We know that
      	precision < 5 will never work, because target set contains less numbers
      	than uint16 range.
      
      Use smart pointer in textFont and textColor
      
      Add test for CMYK QColor roundtrip
      
      Support QColor::Cmyk to AnnotColor::colorCMYK conversion
      
      Add simple test for font size. Fix actual/expected args.
      
      Model font name as class Object, type objName
      	Take into account that ISO 32000 says Tf operand is always an object of
      	PDF type "name". Further benefit: class Object introduces ownership
      	semantcis.
      
      Use more std::unique_ptr and fix some coding syle
      	Some places assumed ownership implicitely. Make it more explicit.
      
      Move parse/constructAppearanceString into DefaultAppearance
      	We gain cohesion and automatic memory management.
      
      Fix minor styling issues
      
      Use std::make_unique from C++14
      d4b4be23
    • Tobias Deiminger's avatar
      Fix open review comments from #50 · db0451ab
      Tobias Deiminger authored and Albert Astals Cid's avatar Albert Astals Cid committed
      Make fontTag optional for AnnotFreeText::parseAppearanceString.
      Handle fontColor == nullptr in AnnotFreeText::constructAppearanceString.
      Use AnnotAppearanceBuilder in AnnotFreeText::constructAppearanceString.
      Delete copy assignment operator for DefaultAppearance.
      Rename setAppearanceString to setDefaultAppearance.
      db0451ab
    • Dileep Sankhla's avatar
      Add annotation font color · 64531344
      Dileep Sankhla authored and Albert Astals Cid's avatar Albert Astals Cid committed
      64531344
  17. 24 Apr, 2018 1 commit
  18. 06 Apr, 2018 1 commit
  19. 05 Apr, 2018 3 commits
  20. 23 Mar, 2018 1 commit
  21. 08 Jan, 2018 1 commit
    • Albert Astals Cid's avatar
      Delete lots of copy constructors and copy assignment operators · 8794789a
      Albert Astals Cid authored
      Fixes rule-of-three and copyable-polymorphic warnings reported by clazy.
      
      The default copy constructor and copy assignment operator are
      only valid for simple classes so we delete them (i.e. make then not exist)
      when we have either a virtual class or a destructor, the code still compiles
      so this doesn't fix any bug, it is more a protection for when you think you
      can copy a class and don't realize the default copy constrcutor is not doing
      what you want and you get crashes. Hopefully this helps us in the future :)
      8794789a
  22. 03 Nov, 2017 1 commit
  23. 21 Oct, 2017 1 commit
  24. 12 May, 2017 1 commit
  25. 08 May, 2017 1 commit
    • Albert Astals Cid's avatar
      New Object API · 9773c153
      Albert Astals Cid authored
      Implement the move operators and copy construtor
      
      Almost all the init() functions are gone and we just have simple
      constructors now
      
      Also made free() public since you're not supposed to call it anymore,
      unless you're being evil and malloc'ing Objects like Array/Dict/XRef
      
      This has a huge reaction chain, most importantly we
      don't get objects by passing a pointer Object parameter, we
      just get the object as a return value, which is a much clearer API
       -  aobj->copy(&obj);
       +  obj = aobj->copy();
      before I was never sure what was being copied into what
      
      Comes with a huge diff, I probably made some mistake in the porting
      since there was lots of copy & paste involved
      9773c153
  26. 08 Mar, 2017 1 commit
  27. 06 Sep, 2016 1 commit
  28. 01 Jun, 2016 1 commit
  29. 13 Aug, 2015 1 commit