Fixes issue #741

Umang Malik authored Mar 16, 2019 and Albert Astals Cid committed Mar 16, 2019

AnnotPolygon::initialize used to look for strings, corrected it to look for names because pdf reference says LE : An array of two names...

rawhide is broken at this point and the current "fedora" has also clazy
1.5 so that's enough for us

Check whether Catalog from XRef is Dict for each document
passed to pdfunite and return error if not.

#706

Left-shifting a negative signed int is undefined. Most compilers shifts the same
way as unsigned ints, but it's better to be clear about it.

It can happen that destroying the pdf tries to log, which needs
globalParams, so destroy globalParams last

Fixes issue #733

Issue #732

Makes code simple and saves getting twice if it's a ref

Similar to the new one in Dict

Simplifies the code

Fixes #728

Saves some copy()

Lots of users can deal with a const & directly, so it saves us some
copying. For the ones that can't move the copy to the caller side.

Some of copy() on the caller side can be easily removed, that will come
on next commits

Albert Astals Cid authored Feb 19, 2019 and Albert Astals Cid committed Feb 19, 2019

oss-fuzz/13203

Did analyze the assembler generated by the more verbose option in
Parser.cc that is a hot path and the assembler was the same

Albert Astals Cid authored Feb 13, 2019 and Albert Astals Cid committed Feb 13, 2019

it's a bit more official looking