1. 25 Nov, 2020 2 commits
  2. 24 Nov, 2020 2 commits
  3. 22 Nov, 2020 1 commit
  4. 20 Nov, 2020 1 commit
  5. 19 Nov, 2020 1 commit
  6. 18 Nov, 2020 1 commit
  7. 17 Nov, 2020 1 commit
    • Oliver Sander's avatar
      Fix annotation line width if no appearance stream or style are given · 331f2f09
      Oliver Sander authored
      When handling annotations without appearance stream, the behavior
      of poppler deviated from what the pdf spec says:  Poppler would
      only take the boundary width from a border style (BS) dictionary
      if the 'style (S)' field was also present, even though the spec
      clearly says that both are optional, and does not mention
      one depending on the other.
      
      This behavior was deliberate, because apparently Acroread 8
      did it that way.  See the comment by Jeff Muizelaar in 28967940.
      But it seems that Acroread behavior has changed, newer versions
      do take the 'width' field into account even when there is no
      'style (S)' field.  The Chromium pdf renderer does the same.
      
      So let's change the code back to following the spec rather
      than an old version of Acroread.
      
      BUG: 988
      331f2f09
  8. 16 Nov, 2020 1 commit
  9. 15 Nov, 2020 7 commits
  10. 14 Nov, 2020 7 commits
    • Albert Astals Cid's avatar
      Update (C) · 91ac0038
      Albert Astals Cid authored
      91ac0038
    • Tobias Deiminger's avatar
      Draw better circles for circle annotations · bd41274e
      Tobias Deiminger authored
      Because PDF spec has no built in circle operator, we can only approximate
      a circle by joining cubic bezier curve segments.
      
      We already did good approximation for line endings and radio buttons by
      setting distance of bezier control point to (4 * (sqrt(2) - 1) / 3) * r.
      But the older AnnotGeometry::draw code for subtype circle still used
      an equivalent of 0.5 * r, which yields a visibly non-circular circle.
      Fix it by using the bezierCircle define for AnnotGeometry too.
      
      Does minor refactoring by introducing AnnotAppearanceBuilder::drawEllipse,
      and forwarding drawCircle to it. typeSquare code is slightly touched as
      a consequence, but remains functionally unchanged.
      
      Also changes 'S' (stroke path) to 's' (close and stroke path). To my
      understanding 'close and stroke' is the correct thing to do here,
      it's in line with drawCircle and the original commit 6c4fa513 didn't
      explain why it left the path open by using 'S'.
      
      Fixes #989.
      bd41274e
    • Kyle Auble's avatar
      cmake: Remove redundant unit-test macro · f4d640d7
      Kyle Auble authored
      poppler_add_unittest was only used 3 times & effectively differed from
      poppler_add_test by just a CMake add_test call.
      f4d640d7
    • Kyle Auble's avatar
      Remove .pc files for private back-ends · 85f6354f
      Kyle Auble authored
      85f6354f
    • Kyle Auble's avatar
      cmake: Remove obsolete version-check macro · 268696eb
      Kyle Auble authored
      Only used once to check pkgconfig >= 0.18 (released in 2005 at latest).
      268696eb
    • Kyle Auble's avatar
      cmake: Remove obsolete bool-to-binary macro · 89f219c8
      Kyle Auble authored
      Only used once & no longer needed; CMake configure_file converts
      True/False to def/undef transparently now.
      89f219c8
    • Albert Astals Cid's avatar
      gcc: Enable -fno-operator-names · a01a75d6
      Albert Astals Cid authored
      They are valid C++ but it's not what this project uses, it's a matter of
      uniformity (same reason we have clang-format for example)
      a01a75d6
  11. 11 Nov, 2020 1 commit
  12. 02 Nov, 2020 3 commits
  13. 01 Nov, 2020 7 commits
  14. 30 Oct, 2020 2 commits
  15. 29 Oct, 2020 3 commits