... since it's not for just stdin anymore.

... since it's not for just stdin anymore.

And make it required

Since the CI is now failing to compile with 6.0

Mahmoud Khalil authored Sep 12, 2021 and Albert Astals Cid committed Sep 12, 2021

This commit improves Poppler support for custom stamp
annotations, by adding a new class called AnnotStampImageHelper in
Poppler core.

The new class takes image data and create an Image
XObject in the document, the AnnotStamp class has been modified to
support the new helper class and to reference the created XObject.

This new implementation has been exposed in the qt5 wrapper as well as the
qt6 one, in which the extraction of the QImage data has been handled.

A new API for preserving the annotation AP stream has been exposed using
the qt wrapper as well, so that users are able to temporarily store it.

Poppler overrides the user-provided CMAKE_{C,CXX}_FLAGS and appends them
to the per-configuration variables instead. This behaviour currently
causes cross-compilation checks to fail since a CMake issue means these
these per-configuration flags are no passed to try_compile() commands.
In my case the flags specified in the toolchain file (as part of
CMAKE_{C,CXX}_FLAGS_INIT) are absolutely required to compile successfully
since a missing `-mabi=/-march=` flag will result in a linker error due to
trying to link incompatible libraries. If CMAKE_TRY_COMPILE_CONFIGURATION
is empty CMake will no propagate the per-configuration flags to
try_compile() so we have to to set the value explicitly.

This is an upstream CMake issue:
See https://gitlab.kitware.com/cmake/cmake/-/issues/22414 and
https://gitlab.kitware.com/cmake/cmake/-/issues/19512.

See CMake documentation:
```
Call the cmake_minimum_required() command at the beginning of the top-level
CMakeLists.txt file even before calling the project() command. It is
important to establish version and policy settings before invoking other
commands whose behavior they may affect. See also policy CMP0000.
```

Uli Schlachter authored Jul 01, 2021 and Albert Astals Cid committed Jul 04, 2021

When I run "cmake -DENABLE_DCTDECODER=none -DENABLE_BOOST=OFF" on my
system, I get the following output:

    -- Found Iconv: /usr/lib/x86_64-linux-gnu/libc.so
    CMake Warning at CMakeLists.txt:252 (find_package):
      By not providing "FindOpenJPEG.cmake" in CMAKE_MODULE_PATH this project has
      asked CMake to find a package configuration file provided by "OpenJPEG",
      but CMake did not find one.

      Could not find a package configuration file provided by "OpenJPEG" with any
      of the following names:

        OpenJPEGConfig.cmake
        openjpeg-config.cmake

      Add the installation prefix of "OpenJPEG" to CMAKE_PREFIX_PATH or set
      "OpenJPEG_DIR" to a directory containing one of the above files.  If
      "OpenJPEG" provides a separate development package or SDK, be sure it has
      been installed.

    CMake Error at CMakeLists.txt:255 (message):
      Install libopenjpeg2 before trying to build poppler.  You can also decide
      to use the internal unmaintained JPX decoder or none at all.

    -- Configuring incomplete, errors occurred!
    See also "/tmp/poppler/build/CMakeFiles/CMakeOutput.log".
    See also "/tmp/poppler/build/CMakeFiles/CMakeError.log".

To figure out what exactly to do now, I have to read some
CMakeLists.txt. This commit improves the situation by producing the
following output instead:

    -- Found Iconv: /usr/lib/x86_64-linux-gnu/libc.so
    CMake Warning at CMakeLists.txt:254 (find_package):
      By not providing "FindOpenJPEG.cmake" in CMAKE_MODULE_PATH this project has
      asked CMake to find a package configuration file provided by "OpenJPEG",
      but CMake did not find one.

      Could not find a package configuration file provided by "OpenJPEG" with any
      of the following names:

        OpenJPEGConfig.cmake
        openjpeg-config.cmake

      Add the installation prefix of "OpenJPEG" to CMAKE_PREFIX_PATH or set
      "OpenJPEG_DIR" to a directory containing one of the above files.  If
      "OpenJPEG" provides a separate development package or SDK, be sure it has
      been installed.

    -- Could NOT find openjpeg2.
    CMake Error at CMakeLists.txt:258 (message):
      Install libopenjpeg2 before trying to build poppler.  You can also decide
      to use the internal unmaintained JPX decoder or none at all.

      Possible options are: -DENABLE_LIBOPENJPEG=openjpeg2,
      -DENABLE_LIBOPENJPEG=none, -DENABLE_LIBOPENJPEG=unmaintained,

    -- Configuring incomplete, errors occurred!
    See also "/tmp/poppler/build/CMakeFiles/CMakeOutput.log".
    See also "/tmp/poppler/build/CMakeFiles/CMakeError.log".
Signed-off-by: Uli Schlachter <psychon@znc.in>

Uli Schlachter authored Jul 01, 2021 and Albert Astals Cid committed Jul 04, 2021

When I run cmake on my system, I get the following output:

    -- Checking for module 'nss>=3.19'
    --   Package 'nss', required by 'virtual:world', not found
    -- Could NOT find NSS3 (missing: NSS3_LIBRARIES NSS3_CFLAGS)
    CMake Error at CMakeLists.txt:149 (message):
      Install libjpeg before trying to build poppler.  You can also decide to use
      the internal unmaintained DCT decoder or none at all.

    -- Configuring incomplete, errors occurred!
    See also "/tmp/poppler/build/CMakeFiles/CMakeOutput.log".
    See also "/tmp/poppler/build/CMakeFiles/CMakeError.log".

Being (badly) trained in CMake errors, I see "Could NOT find NSS3" and
conclude that this is the problem. I do not even read the actual error
message.

This commit improves the situation by producing the following output
instead:

    -- Checking for module 'nss>=3.19'
    --   Package 'nss', required by 'virtual:world', not found
    -- Could NOT find NSS3 (missing: NSS3_LIBRARIES NSS3_CFLAGS)
    -- Could NOT find libjpeg.
    CMake Error at CMakeLists.txt:150 (message):
      Install libjpeg before trying to build poppler.  You can also decide to use
      the internal unmaintained DCT decoder or none at all.

      Possible options are: -DENABLE_DCTDECODER=libjpeg,
      -DENABLE_DCTDECODER=none, -DENABLE_DCTDECODER=unmaintained

    -- Configuring incomplete, errors occurred!
    See also "/tmp/poppler/build/CMakeFiles/CMakeOutput.log".
    See also "/tmp/poppler/build/CMakeFiles/CMakeError.log".

This also explicitly lists the possible values for the parameter that I
figured out by reading the code around CMakeLists.txt:151.
Signed-off-by: Uli Schlachter <psychon@znc.in>

poppler/poppler#1080

Volker Krause authored Apr 11, 2021 and Albert Astals Cid committed Apr 11, 2021

This is consistent with all the other test programs, and helps in
environments where building regular executables doesn't work out of
the box, such as the Android x86 32bit environment I have here.

Albert Astals Cid authored Jan 17, 2021 and Albert Astals Cid committed Mar 01, 2021

Use cmake for better import/export defines

Only used once to check pkgconfig >= 0.18 (released in 2005 at latest).

Only used once & no longer needed; CMake configure_file converts
True/False to def/undef transparently now.