Skip to content

throbber: Don't skip last frame when waiting for end.

Michal Srb requested to merge michalsrb/plymouth:fix-infinite-throbber into master

If the stop_trigger is set and we are waiting for the last frame to stop the animation, make sure we don't accidentally skip the last frame. It could happen if the machine is busy and can't keep up with the frames or when the animation has more than 60 frames (30FPS * 2 seconds).

This is fix for downstream bug in openSUSE: https://bugzilla.opensuse.org/show_bug.cgi?id=1110199 (relevant info from comment 40)

The openSUSE Leap plymouth theme has 73 frames for the throbber animation. (Strange, I know, I have now requested to reduce it to 60 frames). This way the last frame is usually skipped until some random timing in the system makes it finally hit the last frame. This caused that plymouth ran many more loops of the throbber animation after being told to quit.

Edited by Michal Srb

Merge request reports