Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • P plymouth
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 85
    • Issues 85
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • plymouth
  • plymouth
  • Merge requests
  • !43

The source project of this merge request has been removed.
Closed
Created Jul 12, 2019 by Sebastien@seb128
  • Report abuse
Report abuse

fix split writes for long server responces

  • Overview 2
  • Changes 1

The client is reading the servers repsonses in a non-blocking environment and will not cope if the stream does not contain all of the expected data. This leads it to read an "answer included" response and not find the expected size. Leading to unexpected command failures. . Guarentee the entire message is available by packing the various parts into a buffer and submitting it as a single unit. This will ensure as far as possible that we will not get the first byte without the rest being present. . In a perfect world the consumer would cope with short buffers, and internally buffer those until the remainder arrives.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: split-writes-fix