Skip to content

two-step: Fix crash asking for password with multiple heads

Commit 9639ed89 ("two-step: Fix animation not starting on later added heads") unconditionally calls view_start_progress_animation() when adding secondary heads, to fix the animation not running on secondary heads when not asking for a password.

But we should not start the animation when adding a head after we've already entered PLY_BOOT_SPLASH_DISPLAY_PASSWORD_ENTRY state, otherwise we end up starting it a second time when the user is done entering his password, causing plymouth to crash and the boot to hang.

We already have the is_animating bool to indicate whether animations have been started or not, use this to decide if we should start the animation when adding a new head, fixing the crash.

Fixes: 9639ed89 ("two-step: Fix animation not starting on ... added heads") Signed-off-by: Hans de Goede hdegoede@redhat.com

Merge request reports