Skip to content

spa: fix c90 header include

psykose requested to merge psykose1/pipewire:isoc90 into master

placing declarations after code is invalid under ISO c90

fixes the following error when building sdl2 with pipewire, on alpine linux edge:

ninja: job failed: /usr/lib/ccache/bin/gcc -DSDL2_EXPORTS -DUSING_GENERATED_CONFIG_H -I/home/demon/src/aports/community/sdl2/src/SDL2-2.0.20/build/include -I/home/demon/src/aports/community/sdl2/src/SDL2-2.0.20/include -I/usr/include/libdrm -I/home/demon/src/aports/community/sdl2/src/SDL2-2.0.20/build/wayland-generated-protocols -O2 -pipe -fomit-frame-pointer -march=native -fstack-clash-protection -ftree-vectorize -g -idirafter "/home/demon/src/aports/community/sdl2/src/SDL2-2.0.20/src/video/khronos" -I/usr/include/libusb-1.0 -DHAVE_LINUX_VERSION_H -I/usr/include/libdrm -I/usr/include/directfb -I/usr/include -D_REENTRANT -I/usr/include/spa-0.2 -I/usr/include/pipewire-0.3 -msse3 -msse2 -msse -m3dnow -mmmx -fdiagnostics-color=always -Wshadow -fvisibility=hidden -Wdeclaration-after-statement -Werror=declaration-after-statement -fno-strict-aliasing -Wall  -Os -DNDEBUG -fPIC -MD -MT CMakeFiles/SDL2.dir/src/audio/pipewire/SDL_pipewire.c.o -MF CMakeFiles/SDL2.dir/src/audio/pipewire/SDL_pipewire.c.o.d -o CMakeFiles/SDL2.dir/src/audio/pipewire/SDL_pipewire.c.o -c /home/demon/src/aports/community/sdl2/src/SDL2-2.0.20/src/audio/pipewire/SDL_pipewire.c
In file included from /usr/include/pipewire-0.3/pipewire/properties.h:35,
                 from /usr/include/pipewire-0.3/pipewire/core.h:87,
                 from /usr/include/pipewire-0.3/pipewire/context.h:67,
                 from /usr/include/pipewire-0.3/pipewire/protocol.h:46,
                 from /usr/include/pipewire-0.3/pipewire/proxy.h:108,
                 from /usr/include/pipewire-0.3/pipewire/client.h:35,
                 from /usr/include/pipewire-0.3/pipewire/pipewire.h:35,
                 from /home/demon/src/aports/community/sdl2/src/SDL2-2.0.20/src/audio/pipewire/SDL_pipewire.h:28,
                 from /home/demon/src/aports/community/sdl2/src/SDL2-2.0.20/src/audio/pipewire/SDL_pipewire.c:29:
/usr/include/spa-0.2/spa/utils/string.h: In function 'spa_strtof':
/usr/include/spa-0.2/spa/utils/string.h:282:9: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
  282 |         locale_t prev;
      |         ^~~~~~~~
/usr/include/spa-0.2/spa/utils/string.h: In function 'spa_strtod':
/usr/include/spa-0.2/spa/utils/string.h:326:9: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
  326 |         locale_t prev;
      |         ^~~~~~~~
cc1: some warnings being treated as errors
Edited by psykose

Merge request reports