Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pipewire pipewire
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 641
    • Issues 641
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 17
    • Merge requests 17
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PipeWirePipeWire
  • pipewirepipewire
  • Issues
  • #2943
Closed
Open
Issue created Jan 09, 2023 by Robert Mader@rmaderContributor

Dmabuf modifier 0 (== DRM_FORMAT_MOD_LINEAR) handled wrong in several places

It's somewhat unfortunate, but the modifier 0 is actually a valid value and very common: DRM_FORMAT_MOD_LINEAR (while at the same time also meaning DRM_FORMAT_INVALID and DRM_FORMAT_MOD_NONE). Probably it's even the most commonly used modifier apart from DRM_FORMAT_MOD_INVALID (which, again somewhat counter-intuitively, usually means "implicit") and it's currently always used by libcamera. Right now there are several places such as spa_format_video_raw_build() and spa_libcamera_enum_format() that handle this wrong.

It's quite annoying, but there doesn't seem to a exist a usable placeholder value in drm_fourcc.h and an extra field is likely required :(

Edited Jan 09, 2023 by Robert Mader
Assignee
Assign to
Time tracking