Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • pipewire pipewire
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 441
    • Issues 441
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PipeWire
  • pipewirepipewire
  • Issues
  • #1120
Closed
Open
Created Apr 29, 2021 by Robert Mader@rmader

Latest pipewire.h defines "_(String)" in a pipewire specific way

After the latest Fedora update to 0.3.26-3.fc34 several projects such as Mutter complain about redefinition of _. E.g.:

In file included from ../src/backends/meta-screen-cast.c:27:
/usr/include/pipewire-0.3/pipewire/pipewire.h:161: warning: "_" redefined
  161 | #define _(String)       (pw_gettext(String))
      | 
In file included from ../src/core/util-private.h:28,
                 from ../src/backends/meta-monitor-transform.h:25,
                 from ../src/backends/meta-monitor-manager-private.h:34,
                 from ../src/backends/meta-backend-private.h:39,
                 from ../src/backends/meta-screen-cast.h:28,
                 from ../src/backends/meta-screen-cast.c:25:
/usr/include/glib-2.0/glib/gi18n-lib.h:30: note: this is the location of the previous definition
   30 | #define  _(String) ((char *) g_dgettext (GETTEXT_PACKAGE, String))

I think it makes sense to not define such a commonly used name in a publicly exposed header.

Edited Apr 29, 2021 by Robert Mader
Assignee
Assign to
Time tracking