Fixes #1136

So that we don't need to allocate large memory blocks that are mostly
unused.

See #1840

Instead of calculating the target rate and overriding it in some
conditions, calculate it only if it is necessary. This change also
eliminates a set of conditional branches that have the same outcome,
which causes clang-tidy to produce a bugprone-branch-clone warning.

The definition of the `systemdsystemunitdir` variable uses `rootprefix`
instead of `prefix`:

https://github.com/systemd/systemd/blob/v250/src/core/systemd.pc.in#L23



Signed-off-by: Petros Angelatos <petrosagg@gmail.com>

For example, pulseaudio.js[1] immediately sends a
GET_SERVER_INFO request after AUTH, and only later
issues a SET_CLIENT_NAME.

See #1966.

[1]: https://github.com/janakj/pulseaudio.js

By default require that a client is authenticated and
has a manager to be allowed to run a command.

Specially:
 * AUTH requires nothing
 * SET_CLIENT_NAME and STAT only require authentication

Add a new flag to the client struct which saves whether or not
the client has successfully authenticated itself.

This reverts commit 08b18b9d.

This was likely caused by a bug in mpv

Fixes #1956

Add support for Worker.
Add Options feature.
Pass support in plugin load.

Two `pw_properties` objects are not freed in the error path.
Resolves Coverity issues: 1468665, 1468666, 1468667, 1468668.

Furthermore, the module argument string is also not freed.

Use lowercase letters consistently and report errors.

Keep the TXT records for each service,
and reuse them when publishing, if possible.

Keep track of the created services in two lists: published, pending.
Move services between the lists as the avahi client's state changes:
keep services in the pending list until the avahi daemon appears on dbus,
move them to the pending list if connection is lost,
and re-publish them after reconnection.

Add `pw_manager_object_get_data()` which can fetch linked
data by its id. And use it in the zeroconf-publish module.

The service name cannot exceed AVAHI_LABEL_MAX-1 characters in length,
so store it in the service struct instead of dynamically allocating it.

Use a fixed object data id for storing the service of each
pw_manager_object instead of always generating the
service name and using that.

When a module's `load()` fails, its `unload()` will unconditionally
be called. Freeing resource in `load()` while not marking those
resources freed (e.g. setting the pointers to NULL) will result
in double-free when the module's `unload()` method is called.

The `key` member in `struct service` is not used. Remove it.

Rename `get_service()` to `create_service()`,
and `get_service_data()` to `fill_service_data()`.

Whether the object is a sink or source is already queried at the
beginning of the function, and is kept in local variables.
Use those instead of calling `pw_manager_object_is_{sink,source}()` again.

Barnabás Pőcze authored Nov 05, 2021 and Wim Taymans committed Dec 28, 2021

Do not use the client's connection to create the adapter object,
instead, create a new connection. This avoids the need for setting
object.linger=true, which guarantees that when the pulse server goes
down, the null sink is cleaned up.

Barnabás Pőcze authored Dec 28, 2021 and Wim Taymans committed Dec 28, 2021

While it is not a problem since `module_free()` calls
`pw_work_queue_cancel()`, it is completely unnecessary
to do it more than once.

Introduce a new flag on the module which stores whether or
not an unloading has been scheduled.

Barnabás Pőcze authored Nov 05, 2021 and Wim Taymans committed Dec 28, 2021

Since `module_list` is a fixed-sized array, `SPA_FOR_EACH_ELEMENT()`
can be used. So use that. This way there is no need for explicit
indexing nor a sentinel at the end.

Barnabás Pőcze authored Nov 05, 2021 and Wim Taymans committed Dec 28, 2021

The module-roc-{sink,source} modules simply load the corresponding
native pipewire modules, they have no dependency on ROC.
So always compile them. This way these modules are
compile tested, and if the corresponding pipewire
modules are added to the system later, they will work
with no changes to the protocol-pulse module.

Instead of hard-coding the paths relative to the project root,
retrieve the correct paths from `pipewire_dep`.

Instead of hard-coding the path relative to the project root,
retrieve the correct path from `spa_dep`.

Use `meson.project_{build,source}_root()` instead of
`meson.{build,source}_root()` because those functions
do not work as expected when used inside a subproject,
and they have been deprecated in meson 0.56.0.

Use `get_variable()` on the dependency instead of `get_pkgconfig_variable()`
as that has been deprecated in meson 0.56.0.

The paths are calculated relative to the project root,
so use the appropriate functions to retrieve it
instead of using the current build/source directory.

The "gnome" meson module is not used, do not import it.

The `top_srcdir` and `top_builddir` variables are not used
in any of the man page templates. Remove them.

Commit d06a2e21
added support for finding libcamera under two different
names. However, due to breaking changes in libcamera[1],
the current codebase only supports the latest version,
thus drop support for the old name.

[1]: see commit 57dae3e2

Use `spa_dep` everywhere instead of `spa_inc`,
and remove `spa_inc` altogether.