audiobasesrc: always acquire if not acquired in _setcaps
audiobasesrc's setcaps contains an optimization that makes it not re- acquire the ringbuffer if the caps have not changed. However, it doesn't check if it has successfully acquired it or not. It's possible to have the caps set but not having ringbuffer acquired if the previous attempt to acquire fails. This commit replaces the caps existence check with whether the ringbuffer is acquired or not. There's no need to check for caps existence because 1.) it's unlikely to be NULL if the ringbuffer is acquired, and 2.) _setcaps shouldn't be called with a NULL caps. This should also let the element retry on acquiring ringbuffer after an error by re-setting the element's state to READY and back to PLAYING. Whether this behavior is correct is up for debate.
Status | Job ID | Name | Coverage | ||||||
---|---|---|---|---|---|---|---|---|---|
Build Docker | |||||||||
passed |
#5649614
|
alpine amd64 manifest builder docker |
00:00:35
|
|
|||||
passed |
#5649613
|
android docker |
00:02:54
|
|
|||||
passed |
#5649611
|
cerbero fedora amd64 docker |
00:03:01
|
|
|||||
passed |
#5649609
|
fedora amd64 docker |
00:03:33
|
|
|||||
passed |
#5649616
|
gst-indent amd64 docker |
00:00:37
|
|
|||||
Preparation | |||||||||
passed |
#5649620
|
gst indent |
00:00:10
|
|
|||||
manual |
#5649618
manual
|
manifest |
|
||||||
Build | |||||||||
created |
#5649637
gstreamer
|
build cerbero cross-android universal |
|
||||||
created |
#5649645
gst-ios-13.2
|
build cerbero cross-ios universal |
|
||||||
created |
#5649639
gstreamer
|
build cerbero cross win32 |
|
||||||
created |
#5649641
gstreamer
|
build cerbero cross win64 |
|
||||||
created |
#5649635
gstreamer
|
build cerbero fedora x86_64 |
|
||||||
created |
#5649643
gst-macos-10.15
|
build cerbero macos x86_64 |
|
||||||
created |
#5649647
1809
gstreamer-windows
windows
docker
|
build cerbero msvc x86_64 |
|
||||||
created |
#5649626
|
build clang fedora x86_64 |
|
||||||
created |
#5649632
1809
windows
docker
allowed to fail
manual
|
build msys2 |
|
||||||
created |
#5649621
|
build nodebug fedora x86_64 |
|
||||||
created |
#5649622
|
build static fedora x86_64 |
|
||||||
created |
#5649624
|
build static nodebug fedora x86_64 |
|
||||||
created |
#5649627
1809
windows
docker
|
build vs2017 amd64 |
|
||||||
created |
#5649630
1809
windows
docker
|
build vs2017 x86 |
|
||||||
Test | |||||||||
created |
#5649648
gstreamer
|
check fedora |
|
||||||
created |
#5649649
gstreamer
|
integration testsuites fedora 1/4 |
|
||||||
created |
#5649650
gstreamer
|
integration testsuites fedora 2/4 |
|
||||||
created |
#5649651
gstreamer
|
integration testsuites fedora 3/4 |
|
||||||
created |
#5649652
gstreamer
|
integration testsuites fedora 4/4 |
|
||||||
created |
#5649656
gstreamer
|
valgrind bad |
|
||||||
created |
#5649653
gstreamer
|
valgrind base |
|
||||||
created |
#5649657
gstreamer
|
valgrind ges |
|
||||||
created |
#5649654
gstreamer
|
valgrind good |
|
||||||
created |
#5649655
gstreamer
|
valgrind ugly |
|
||||||
Integrate | |||||||||
created |
#5649658
|
cross-android universal examples |
|
||||||
created |
#5649660
gst-ios-13.2
|
cross-ios universal examples |
|
||||||
created |
#5649659
|
documentation |
|
||||||