1. 05 Mar, 2019 1 commit
    • Arkadiusz Hiler's avatar
      views: Fix typo in dictionary key · cf1de39f
      Arkadiusz Hiler authored
      One extra "s" in "messages", which was causing the following exception
      when bulk updating patches with no patches selected:
      
        File "/srv/patchwork.freedesktop.org/lib/apache2/../../patchwork/views/__init__.py" in process_multiplepatch_form
          157.         context['messsages'] += ["No patches selected; nothing updated"]
      
        Exception Type: KeyError
        Exception Value: 'messsages'
      Signed-off-by: Arkadiusz Hiler's avatarArkadiusz Hiler <arkadiusz.hiler@intel.com>
      cf1de39f
  2. 04 Mar, 2019 1 commit
  3. 28 Feb, 2019 4 commits
  4. 13 Feb, 2019 6 commits
  5. 28 Jan, 2019 1 commit
  6. 25 Jan, 2019 2 commits
    • Arkadiusz Hiler's avatar
      parsemail: Use new cover letter if provided · 13cfb0cf
      Arkadiusz Hiler authored
      Due to complex handling of incoming series all the new cover letters
      were not used.
      
      parsemail creates new, transient revision that is later discarded.
      Everything that should get persistent in the proper revision has to be
      copied over explicitly in on_revision_complete signal handler.
      
      So let's do that for all the cover_letter fields, but only if they are
      present.
      Signed-off-by: Arkadiusz Hiler's avatarArkadiusz Hiler <arkadiusz.hiler@intel.com>
      13cfb0cf
    • Arkadiusz Hiler's avatar
      parsemail: Fix cover letter handling · 67a63377
      Arkadiusz Hiler authored
      If cover letter looked like a patch (i.e. had the diff markers) it was
      parsed as such, resulting in the diff being extracted out from the
      contents and stored as oddly numbered patch 0.
      
      Let's store the raw payload and do not create patches out of cover
      letters.
      
      This is now tested by adding some diff excerpt to one of the test
      fixtures and adjusting the asserts on cover_letter and raw_cover_letter
      accordingly.
      Signed-off-by: Arkadiusz Hiler's avatarArkadiusz Hiler <arkadiusz.hiler@intel.com>
      67a63377
  7. 07 Jan, 2019 6 commits
  8. 04 Jan, 2019 1 commit
  9. 03 Jan, 2019 2 commits
  10. 02 Jan, 2019 2 commits
  11. 17 Dec, 2018 1 commit
  12. 10 Dec, 2018 1 commit
  13. 07 Dec, 2018 3 commits
  14. 05 Dec, 2018 1 commit
  15. 28 Nov, 2018 3 commits
  16. 27 Nov, 2018 3 commits
  17. 24 Nov, 2018 1 commit
    • Andrei Vagin's avatar
      permissions: add a fast path for non-authenticated users · 142e8fab
      Andrei Vagin authored
      patchwork returns a following back-trace without this patch:
      
      Internal Server Error: /patch/858/
      Traceback (most recent call last):
        File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py", line 132, in get_response
          response = wrapped_callback(request, *callback_args, **callback_kwargs)
        File "/srv/patchwork/lib/apache2/../../patchwork/views/patch.py", line 34, in patch
          editable = Can(request.user).edit(patch)
        File "/srv/patchwork/lib/apache2/../../patchwork/permissions.py", line 38, in edit
          can.edit(patch.project)))
        File "/srv/patchwork/lib/apache2/../../patchwork/permissions.py", line 32, in edit
          project in self.user.profile.maintainer_projects.all())
        File "/usr/lib/python2.7/site-packages/django/utils/functional.py", line 226, in inner
          return func(self._wrapped, *args)
      AttributeError: 'AnonymousUser' object has no attribute 'profile'
      
      Fixes: e876b068 ("permissions: Introduce central point for defining permissions")
      142e8fab
  18. 18 Jun, 2018 1 commit