patchwork-fdo issueshttps://gitlab.freedesktop.org/patchwork-fdo/patchwork-fdo/-/issues2018-11-28T13:22:34Zhttps://gitlab.freedesktop.org/patchwork-fdo/patchwork-fdo/-/issues/3Smarter retest button2018-11-28T13:22:34ZArkadiusz HilerSmarter retest buttonNow it's possible to request multiple retests in a row. We should be smarter about that showing when the last retest was requested and/or blocking the button for some grace period.Now it's possible to request multiple retests in a row. We should be smarter about that showing when the last retest was requested and/or blocking the button for some grace period.https://gitlab.freedesktop.org/patchwork-fdo/patchwork-fdo/-/issues/1be explicit about series revisions being incomplete2018-11-28T13:23:10ZArkadiusz Hilerbe explicit about series revisions being incompleteWhen a revision of a series is incomplete, it's not immediately obvious. One can infer that, after careful inspection, from the missing patch numbers in patch sequence, but let's leverage machines to do that for us.
We should have a red...When a revision of a series is incomplete, it's not immediately obvious. One can infer that, after careful inspection, from the missing patch numbers in patch sequence, but let's leverage machines to do that for us.
We should have a red notice about the state of the series, with some explanation why is that.Arkadiusz HilerArkadiusz Hilerhttps://gitlab.freedesktop.org/patchwork-fdo/patchwork-fdo/-/issues/7Show newly created rerun revision2018-12-10T08:37:22ZArkadiusz HilerShow newly created rerun revisionNow, when rerun button is hit, it changes to green and nothing else visible to the user happens.
The UI should update to show the newly created rerun revision, with appropriate markings, and show the updated series dates.Now, when rerun button is hit, it changes to green and nothing else visible to the user happens.
The UI should update to show the newly created rerun revision, with appropriate markings, and show the updated series dates.https://gitlab.freedesktop.org/patchwork-fdo/patchwork-fdo/-/issues/8Fix revision linking in the series view2018-12-17T15:09:51ZArkadiusz HilerFix revision linking in the series viewIf you look at an URL that is used for revision selecting (e.g. "rev 1" on https://patchwork.freedesktop.org/series/51519/)
it goes to #revN, but when clicked it does the update dynamically and does not update the in-browser URL.
When ...If you look at an URL that is used for revision selecting (e.g. "rev 1" on https://patchwork.freedesktop.org/series/51519/)
it goes to #revN, but when clicked it does the update dynamically and does not update the in-browser URL.
When the anchor is used (e.g. https://patchwork.freedesktop.org/series/51519/#rev1) it does not work - the page is still on the latest revision.
Needed for gfx-ci/i915-infra#10Arkadiusz HilerArkadiusz Hilerhttps://gitlab.freedesktop.org/patchwork-fdo/patchwork-fdo/-/issues/2retest button is broken in non-obvious way on incomplete revision2018-12-19T09:01:30ZArkadiusz Hilerretest button is broken in non-obvious way on incomplete revisionWhen the series is incomplete, the retest button is there, but it broken - clicking it results in a fail.
This is because the revision number component is missing from the URL, e.g.:
```
instead of https://patchwork.freedesktop.org/api...When the series is incomplete, the retest button is there, but it broken - clicking it results in a fail.
This is because the revision number component is missing from the URL, e.g.:
```
instead of https://patchwork.freedesktop.org/api/1.0/series/50443/revisions/5/newrevision/
we get https://patchwork.freedesktop.org/api/1.0/series/50443/revisions//newrevision/
```
Which results in 405 Method Not Allowed response.
related to #1Arkadiusz HilerArkadiusz Hilerhttps://gitlab.freedesktop.org/patchwork-fdo/patchwork-fdo/-/issues/14Create Favicon2019-01-28T10:44:44ZArkadiusz HilerCreate FaviconFirst iteration:![favicon](/uploads/27921acda0bfdbd779fcf1425d8ab79e/favicon.png)First iteration:![favicon](/uploads/27921acda0bfdbd779fcf1425d8ab79e/favicon.png)https://gitlab.freedesktop.org/patchwork-fdo/patchwork-fdo/-/issues/19Keep the diff in a comment2019-02-28T09:26:26ZArkadiusz HilerKeep the diff in a comment**Original email:**
```
I forgot to stage this change:
diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
index f9ad47ea..f3440f31 100644
--- a/tests/intel-ci/blacklist.txt
+++ b/tests/intel-ci/blacklist.txt
@@ -13...**Original email:**
```
I forgot to stage this change:
diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
index f9ad47ea..f3440f31 100644
--- a/tests/intel-ci/blacklist.txt
+++ b/tests/intel-ci/blacklist.txt
@@ -13,7 +13,7 @@ igt@drm_mm(@.*)?
# failures in tests run afterwards.
###############################################
igt@i915_module_load(@.*)?
-igt@pm_rpm@module-reload
+igt@i915_pm_rpm@module-reload
###############################################
# GEM
###############################################
```
**What ends up in patchwork:**
```
I forgot to stage this change:
```
**Example:** https://patchwork.freedesktop.org/patch/286912/
This is caused by the diff section being parsed and removed from the payload. Patchwork should use raw(-ish) payload instead in this case.Arkadiusz HilerArkadiusz Hilerhttps://gitlab.freedesktop.org/patchwork-fdo/patchwork-fdo/-/issues/18Make comments on patches linkable2019-02-28T09:50:42ZArkadiusz HilerMake comments on patches linkablePatchwork collects comments on patches and displays them on a patch view, just below the body.
We should add a feature to hotlink to them, and since they have span with a date already, let's make that our anchor element that's also a li...Patchwork collects comments on patches and displays them on a patch view, just below the body.
We should add a feature to hotlink to them, and since they have span with a date already, let's make that our anchor element that's also a link.
TODO:
* [x] Add id "comment_{comment_id}" to the date span or to the whole header
* [x] make that span "a" linking to "#comment_{comment_id}"
* [x] add css so that the date/header are highlighted when `:target`https://gitlab.freedesktop.org/patchwork-fdo/patchwork-fdo/-/issues/16Request for REST API point: /coverletter/ or /cover/2019-02-28T12:33:15ZTomi SarvelaRequest for REST API point: /coverletter/ or /cover/There is usecase for cover letter inspection in Intel-GFX-CI. While /mbox_with_cover/ can be used, it's slightly unwieldy as the cover letter split from main series has to be done on client side, even if server has done it already.
This...There is usecase for cover letter inspection in Intel-GFX-CI. While /mbox_with_cover/ can be used, it's slightly unwieldy as the cover letter split from main series has to be done on client side, even if server has done it already.
This is a low priority request, as we can live with /mbox_with_cover/ for now.https://gitlab.freedesktop.org/patchwork-fdo/patchwork-fdo/-/issues/15500 when failing to find patches from particular person2019-03-05T13:34:07ZArkadiusz Hiler500 when failing to find patches from particular person`https://patchwork.freedesktop.org/project/intel-gfx/list/?submitter=1234` results in 500 instead of more graceful 404.
```
Traceback:
File "/srv/patchwork.freedesktop.org/.virtualenvs/django-1.11/lib/python2.7/site-packages/django/cor...`https://patchwork.freedesktop.org/project/intel-gfx/list/?submitter=1234` results in 500 instead of more graceful 404.
```
Traceback:
File "/srv/patchwork.freedesktop.org/.virtualenvs/django-1.11/lib/python2.7/site-packages/django/core/handlers/exception.py" in inner
41. response = get_response(request)
File "/srv/patchwork.freedesktop.org/.virtualenvs/django-1.11/lib/python2.7/site-packages/django/core/handlers/base.py" in _legacy_get_response
249. response = self._get_response(request)
File "/srv/patchwork.freedesktop.org/.virtualenvs/django-1.11/lib/python2.7/site-packages/django/core/handlers/base.py" in _get_response
187. response = self.process_exception_by_middleware(e, request)
File "/srv/patchwork.freedesktop.org/.virtualenvs/django-1.11/lib/python2.7/site-packages/django/core/handlers/base.py" in _get_response
185. response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/srv/patchwork.freedesktop.org/lib/apache2/../../patchwork/views/patch.py" in list
125. view_args={'project_id': project.linkname})
File "/srv/patchwork.freedesktop.org/lib/apache2/../../patchwork/views/__init__.py" in generic_list
44. filters = Filters(request)
File "/srv/patchwork.freedesktop.org/lib/apache2/../../patchwork/filters.py" in __init__
425. f.parse(self.dict)
File "/srv/patchwork.freedesktop.org/lib/apache2/../../patchwork/filters.py" in parse
61. self._set_key(dict[self.param])
File "/srv/patchwork.freedesktop.org/lib/apache2/../../patchwork/filters.py" in _set_key
108. self.person = Person.objects.get(id=int(str))
File "/srv/patchwork.freedesktop.org/.virtualenvs/django-1.11/lib/python2.7/site-packages/django/db/models/manager.py" in manager_method
85. return getattr(self.get_queryset(), name)(*args, **kwargs)
File "/srv/patchwork.freedesktop.org/.virtualenvs/django-1.11/lib/python2.7/site-packages/django/db/models/query.py" in get
380. self.model._meta.object_name
Exception Type: DoesNotExist at /project/intel-gfx/list/
Exception Value: Person matching query does not exist.
Request information:
USER: AnonymousUser
GET:
submitter = u'1234'
```https://gitlab.freedesktop.org/patchwork-fdo/patchwork-fdo/-/issues/13Move from one patch to the next in a series2019-03-06T13:19:02ZFrancesco BalestrieriMove from one patch to the next in a seriesWhen looking at patches in a series, it would be useful to be able to move to the next patch in the series without having to go back to the series overview.When looking at patches in a series, it would be useful to be able to move to the next patch in the series without having to go back to the series overview.Arkadiusz HilerArkadiusz Hilerhttps://gitlab.freedesktop.org/patchwork-fdo/patchwork-fdo/-/issues/20Cover letter not stored properly when the seriess has just one patch2019-04-01T10:57:16ZArkadiusz HilerCover letter not stored properly when the seriess has just one patch**Patchwork:** https://patchwork.freedesktop.org/series/58795/#rev1<br/>
**Mail Archive:** https://lists.freedesktop.org/archives/intel-gfx-trybot/2019-March/067574.html
Needs regression tests and fixes in the impl.
Reported by @jheikkil**Patchwork:** https://patchwork.freedesktop.org/series/58795/#rev1<br/>
**Mail Archive:** https://lists.freedesktop.org/archives/intel-gfx-trybot/2019-March/067574.html
Needs regression tests and fixes in the impl.
Reported by @jheikkilArkadiusz HilerArkadiusz Hilerhttps://gitlab.freedesktop.org/patchwork-fdo/patchwork-fdo/-/issues/21kbuild test bot stealing authorship2019-04-11T05:10:14ZArkadiusz Hilerkbuild test bot stealing authorship"kbuild test bot" has taken ownership of this series: https://patchwork.freedesktop.org/series/58990
This is because kbuild sent a patch:
https://patchwork.freedesktop.org/patch/296266/?series=58990&rev=2
And patchwork is unable to und..."kbuild test bot" has taken ownership of this series: https://patchwork.freedesktop.org/series/58990
This is because kbuild sent a patch:
https://patchwork.freedesktop.org/patch/296266/?series=58990&rev=2
And patchwork is unable to understand finesse of those interactions.
Since it is a reply to patch 2 in the series and it contains a diff -
patchwork overwrites that patch with the newer one, creating rev2.
This makes the series not appliable via patchwork.
Since "kbuild test robot" is the last one to update the contents of the
series, it takes ownership.
There are two options how to solve this:
a) ask kbuild owners to add `X-Patchwork-Hint: comment` to the e-mail headers.
b) implement address blocking for Patchworkhttps://gitlab.freedesktop.org/patchwork-fdo/patchwork-fdo/-/issues/17Valid From: on cover letter2019-05-23T08:07:31ZTomi SarvelaValid From: on cover letterThe From: and Subject: on cover letter are mangled when requested through /mbox_with_cover/. I don't see why, and I think this could be considered a bug.
Usecase for this is git-am, which complains about missing ident when coverletter i...The From: and Subject: on cover letter are mangled when requested through /mbox_with_cover/. I don't see why, and I think this could be considered a bug.
Usecase for this is git-am, which complains about missing ident when coverletter is used as a patch. Workaround is git apply && add && commit.https://gitlab.freedesktop.org/patchwork-fdo/patchwork-fdo/-/issues/23Change cover letter when navigating between series versions2019-05-28T12:12:42ZDaniel VetterChange cover letter when navigating between series versions@ivyl said that all cover letters are stored, but only ever the last one is shown. This is annoying if a resend has a much reduced cover letter (e.g. only explaining the changes made, not the entire context of the story again).
Would be...@ivyl said that all cover letters are stored, but only ever the last one is shown. This is annoying if a resend has a much reduced cover letter (e.g. only explaining the changes made, not the entire context of the story again).
Would be nice to change the cover letters together with the patch series when navigating series revisions.Arkadiusz HilerArkadiusz Hilerhttps://gitlab.freedesktop.org/patchwork-fdo/patchwork-fdo/-/issues/10Python 3.7 support2019-07-10T08:27:46ZArkadiusz HilerPython 3.7 supportCurrently we have Python 2.7 and 3.6 support as advertised by `tox.ini`, 3.7 should be rather trivial addition.Currently we have Python 2.7 and 3.6 support as advertised by `tox.ini`, 3.7 should be rather trivial addition.Arkadiusz HilerArkadiusz Hilerhttps://gitlab.freedesktop.org/patchwork-fdo/patchwork-fdo/-/issues/25Lock held on production2019-07-10T11:13:44ZArkadiusz HilerLock held on productionSeems like we are hitting new error on the main deployment (patchwork.freedesktop.org):
```
LockHeld
[Errno 110] Lock held: '/tmp/patchwork.parsemail.lock'
```
Few things to check:
1. figure out how postfix feeds us with emails
2. make...Seems like we are hitting new error on the main deployment (patchwork.freedesktop.org):
```
LockHeld
[Errno 110] Lock held: '/tmp/patchwork.parsemail.lock'
```
Few things to check:
1. figure out how postfix feeds us with emails
2. make sure that we are not feed two mails at the same time
3. consider using transaction instead of locksArkadiusz HilerArkadiusz Hilerhttps://gitlab.freedesktop.org/patchwork-fdo/patchwork-fdo/-/issues/12Ack/Tested-By/Reviewed-By counts on the series view2019-07-22T05:16:05ZArkadiusz HilerAck/Tested-By/Reviewed-By counts on the series viewWe have nice counts on the patches view (e.g. https://patchwork.freedesktop.org/project/intel-gfx/patches/) for the reviewer's tags. We could do the same for the patch list on the series view (e.g. https://patchwork.freedesktop.org/serie...We have nice counts on the patches view (e.g. https://patchwork.freedesktop.org/project/intel-gfx/patches/) for the reviewer's tags. We could do the same for the patch list on the series view (e.g. https://patchwork.freedesktop.org/series/16856/) for improved user experience.https://gitlab.freedesktop.org/patchwork-fdo/patchwork-fdo/-/issues/26git-pw fails to get the config in a worktree setup2019-07-26T06:46:39ZLucas De Marchigit-pw fails to get the config in a worktree setupBy using dim to create the checkout of the kernel tree, I have the following dir structure:
```
[ldmartin@ldmartin-desk1 src]$ git worktree list
linux-dim/src 4fd955732d1e [tip-tgl-batch3-v2]
linux-dim/drm-inte...By using dim to create the checkout of the kernel tree, I have the following dir structure:
```
[ldmartin@ldmartin-desk1 src]$ git worktree list
linux-dim/src 4fd955732d1e [tip-tgl-batch3-v2]
linux-dim/drm-intel-fixes d7e8a19b38c8 [drm-intel-fixes]
linux-dim/drm-intel-next a17ce803dffa [drm-intel-next]
linux-dim/drm-intel-next-fixes c36beba6b296 [drm-intel-next-fixes]
linux-dim/drm-intel-next-queued 5cad0ddf4b78 [drm-intel-next-queued]
linux-dim/drm-misc-fixes 2f040d27080d [drm-misc-fixes]
linux-dim/drm-misc-next 1e9907362453 [drm-misc-next]
linux-dim/drm-misc-next-fixes 7aaddd96d5fe [drm-misc-next-fixes]
linux-dim/drm-rerere bf599a557a56 [rerere-cache]
linux-dim/drm-tip 40ef4755f8a1 [drm-tip]
linux-dim/topic/core-for-CI 3acdd1462f96 [topic/core-for-CI]
linux-dim/topic/remove-fbcon-notifiers 6116b892bd4f [topic/remove-fbcon-notifiers]
```
`src` is the "main tree".
This works:
```
[ldmartin@ldmartin-desk1 src]$ cd src
[ldmartin@ldmartin-desk1 src]$ git config --get patchwork.default.project
intel-gfx
```
This works:
```
[ldmartin@ldmartin-desk1 src]$ cd drm-intel-next-queued
[ldmartin@ldmartin-desk1 drm-intel-next-queued]$ git config --get patchwork.default.project
intel-gfx
```
This doesn't:
```
[ldmartin@ldmartin-desk1 drm-intel-next-queued]$ git pw mbox 63670
fatal: git-pw isn't configured.
Please set up the patchwork url and project, e.g.:
git config patchwork.default.url https://patchwork.freedesktop.org
git config patchwork.default.project intel-gfx
```
It seems to be a bug in GitPython to get the config in a worktree setup?https://gitlab.freedesktop.org/patchwork-fdo/patchwork-fdo/-/issues/28FDO deployment fails to parse a pull request2019-10-21T11:20:32ZArkadiusz HilerFDO deployment fails to parse a pull requestThe mail parses and shows up just fine with local instance of patchwork,
not with the FDO deployed one:
```
patchwork@emeril:/tmp$ /srv/patchwork.freedesktop.org/patchwork/bin/parsemail.sh --verbosity debug < ttm
Message-Id is <1eba1bc0...The mail parses and shows up just fine with local instance of patchwork,
not with the FDO deployed one:
```
patchwork@emeril:/tmp$ /srv/patchwork.freedesktop.org/patchwork/bin/parsemail.sh --verbosity debug < ttm
Message-Id is <1eba1bc0-ba0c-b948-6a3d-51a98f4e5c27@gmail.com>
```
Yet https://patchwork.freedesktop.org/patch/msgid/1eba1bc0-ba0c-b948-6a3d-51a98f4e5c27@gmail.com yields no results.
The only difference is that patchwork.fdo runs on Python 2.7 and the local one uses Python 3. I'll downgrade locally to try to reproduce. If that's the reason I was planning onto upgrading to Python 3 anyway :-)
Affected email: [ttm-pull.mail](/uploads/1b7c672f466857bcd6a687d1334758d0/ttm-pull.mail)Arkadiusz HilerArkadiusz Hiler