GitLab

If navigating to a patch from a series/revision view a ?series=x&rev=y
are appended to the URL.

This is later used on the patch view to determine whether browsing this
patch from the series view. If that's the case new navigation options to
go to next and previous patches in series are available.

Closes #13Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>

Not only it was unused but also used for something else than the name
has indicated.
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>

They were spread all over the place and somewhat duplicated.

This introduces clear notation and a single place to define all the
complicated logic for checking whether someone has permission to do
something.
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>

RequestContext is going to be deprecated in future versions of Django in
favor of simple dictionaries.

This requires us to drop the PatchworkRequestContext class and spread
logic it contained around.

Some of the code made it into context processor but most ended up in
generic_list which actually benefits us in better code locality.
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>

Using the quoted doted path to the view callable object
(e.g. 'patchwork.views.projects') is going to be deprecated soon.
Using either the actual callable or a named URL is recommended.

Let future-proof urls.py by using the actual callables there and
name all the URLs, so we can use the names everywhere else.
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>

It's hard to find the series corresponding to the patch when you have
only the patch URL - you have to go through the author or through the
project and try to find an association with the series name.

Series view is also where the results from CI are shown, so this is the
drill for many people doing the reviews.

Since this is a common issue, let's link the series from the patch page.
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>

In case of cross posting on mailing-lists handled by patchwork we have
duplicated msgids in the DB. So we need to make a choice when asked for
the patch with a give msgid. Otherwise:

Internal Server Error: /patch/msgid/1461691808-12414-20-git-send-email-daniel.vetter@ffwll.ch/
Traceback (most recent call last):
  File "django/core/handlers/base.py", line 132, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "patchwork/views/patch.py", line 128, in msgid
    patch = get_object_or_404(Patch, msgid='<' + msgid + '>')
  File "shortcuts.py", line 155, in get_object_or_404
    return queryset.get(*args, **kwargs)
  File "django/db/models/query.py", line 338, in get
    (self.model._meta.object_name, num)
MultipleObjectsReturned: get() returned more than one Patch -- it returned 2!
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>

It can be handy to tag commit messages to get back to the discussion
from the git log. A new 'link' GET parameter make this possible on all
the mbox entry points, for both patches and series.
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>

Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>

Python 3 is unicode only. While many of the issues with unicode, such
as the now invalid 'u' prefix, have already been resolved, there are a
few more issues.

Many of these issues are related to HTTPResponse.content, which returns
bytes and needs to be "decoded" in order to perform actions like
concatenation with str objects (unicode). Where possible, make use of
assertContains, per the Django documentation (http://bit.ly/1lRDYie),
else fall back to including a 'decode' statement.

v2: Port to fdo's patchwork (Damien)
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>

Run code through the 'modernize' application to fix Python 3
compatibility while also retaining Python 2 backwards compatibility.

There are some key changes made to the autogenerated code:

* Don't wrap 'items()' in 'list' for for loops - it's not necessary
* Don't wrap 'keys()' in 'list' - just drop 'keys()'
* Use Django's version of six rather than the upstream one

Many of the issues found are based upon the changed definitions of the
map, keys and items functions, along with the removal of the iteritems
function and reduce keyword.

v2: Port to fdo's patchwork (Damien)
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>

Imports are easier to read if they are grouped by type (standard
library, third party, application) and organised alphabetically. Make
it so.

v2: Port to fdo's patchwork (Damien)
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>

These are quite limited as patchwork only supports Python 2.6+. As
such, only the 'print_function' and 'absolute_import' statements are
required.

Found using 'modernize'
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>

Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>

Similar to:
http://mid.gmane.org/1443511466-8017-1-git-send-email-jani.nikula@intel.com

It's really handy to be able to find a patchwork patch from the original
mail. For instance, a key stroke in mutt will open the patch page in the
browser.
Suggested-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>

This change updates patchwor to the newer project struture: we've moved
the actual application out of the apps/ directory, and the
patchwork-specific templates to under the patchwork application.

This gives us the manage.py script in the top-level now.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Passing 'mimetype' to 'HttpResponse' is deprecated in 1.6 and
removed in Django 1.7. Among other things, this causes some unit
tests to fail when using Django 1.7. Its replacement - 'content_type'
- is available in Django 1.5+. This can be seen here:

    https://docs.djangoproject.com/en/1.5/ref/request-response/#django.http.HttpResponse.__init__

This is therefore a like-for-like replacement.
Signed-off-by: Stephen Finucane <stephenfinucane@hotmail.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Mbox generation is related to views, not the models themselves. This
change creates a patch_to_mbox function in the views/ directory, which
the actual view handlers use instead of Patch.mbox().
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Signed-off-by: Guilherme Salgado <guilherme.salgado@linaro.org>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

This is so that we can use static analysis tools like pyflakes to find
undefined names (and other common mistakes we often make) without being
swamped with unused imports warnings.
Signed-off-by: Guilherme Salgado <guilherme.salgado@linaro.org>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

These seem to be what was used in the past to archive/unarchive and delete
patches.
Signed-off-by: Guilherme Salgado <guilherme.salgado@linaro.org>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

The number of times I've edited this code and wondered why nothing
changes...
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Bundles can now be reordered and saved.

Add dependency on jquery in INSTALL.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

even when other lines of a method are indented with spaces.

This gets rid of all tabs and uses spaces everywhere.

[Reworked to apply on newer code by Jeremy]
Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

MultiplePatchForm needs a project, so pass one down.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>