1. 19 Jul, 2016 1 commit
    • Damien Lespiau's avatar
      patch: Make the /patch/msgid/ view resilient to duplicate msgids · d8a74c39
      Damien Lespiau authored
      
      
      In case of cross posting on mailing-lists handled by patchwork we have
      duplicated msgids in the DB. So we need to make a choice when asked for
      the patch with a give msgid. Otherwise:
      
      Internal Server Error: /patch/msgid/1461691808-12414-20-git-send-email-daniel.vetter@ffwll.ch/
      Traceback (most recent call last):
        File "django/core/handlers/base.py", line 132, in get_response
          response = wrapped_callback(request, *callback_args, **callback_kwargs)
        File "patchwork/views/patch.py", line 128, in msgid
          patch = get_object_or_404(Patch, msgid='<' + msgid + '>')
        File "shortcuts.py", line 155, in get_object_or_404
          return queryset.get(*args, **kwargs)
        File "django/db/models/query.py", line 338, in get
          (self.model._meta.object_name, num)
      MultipleObjectsReturned: get() returned more than one Patch -- it returned 2!
      Signed-off-by: default avatarDamien Lespiau <damien.lespiau@intel.com>
      d8a74c39
  2. 05 Apr, 2016 1 commit
  3. 18 Feb, 2016 1 commit
  4. 17 Feb, 2016 2 commits
    • Stephen Finucane's avatar
      py3: Resolve unicode issues · 521d387f
      Stephen Finucane authored
      Python 3 is unicode only. While many of the issues with unicode, such
      as the now invalid 'u' prefix, have already been resolved, there are a
      few more issues.
      
      Many of these issues are related to HTTPResponse.content, which returns
      bytes and needs to be "decoded" in order to perform actions like
      concatenation with str objects (unicode). Where possible, make use of
      assertContains, per the Django documentation (http://bit.ly/1lRDYie
      
      ),
      else fall back to including a 'decode' statement.
      
      v2: Port to fdo's patchwork (Damien)
      Signed-off-by: default avatarStephen Finucane <stephen.finucane@intel.com>
      521d387f
    • Stephen Finucane's avatar
      py3: "Modernize" code base · d02ed150
      Stephen Finucane authored
      
      
      Run code through the 'modernize' application to fix Python 3
      compatibility while also retaining Python 2 backwards compatibility.
      
      There are some key changes made to the autogenerated code:
      
      * Don't wrap 'items()' in 'list' for for loops - it's not necessary
      * Don't wrap 'keys()' in 'list' - just drop 'keys()'
      * Use Django's version of six rather than the upstream one
      
      Many of the issues found are based upon the changed definitions of the
      map, keys and items functions, along with the removal of the iteritems
      function and reduce keyword.
      
      v2: Port to fdo's patchwork (Damien)
      Signed-off-by: default avatarStephen Finucane <stephen.finucane@intel.com>
      Signed-off-by: default avatarDamien Lespiau <damien.lespiau@intel.com>
      d02ed150
  5. 16 Feb, 2016 2 commits
  6. 20 Nov, 2015 1 commit
  7. 20 Oct, 2015 1 commit
  8. 27 May, 2015 1 commit
  9. 03 May, 2015 1 commit
  10. 10 Jun, 2013 1 commit
  11. 30 Mar, 2011 1 commit
  12. 15 Mar, 2011 1 commit
  13. 08 Mar, 2011 1 commit
  14. 02 Sep, 2010 1 commit
  15. 08 Feb, 2009 1 commit
  16. 23 Aug, 2008 1 commit
  17. 22 Aug, 2008 1 commit
  18. 21 Aug, 2008 2 commits