1. 23 Jan, 2018 3 commits
  2. 16 Jan, 2018 11 commits
  3. 15 Jan, 2018 4 commits
    • Arkadiusz Hiler's avatar
      urls: Use named URLs · 492485df
      Arkadiusz Hiler authored
      Using the quoted doted path to the view callable object
      (e.g. 'patchwork.views.projects') is going to be deprecated soon.
      Using either the actual callable or a named URL is recommended.
      Let future-proof urls.py by using the actual callables there and
      name all the URLs, so we can use the names everywhere else.
      Signed-off-by: default avatarArkadiusz Hiler <arkadiusz.hiler@intel.com>
    • Arkadiusz Hiler's avatar
      models: Use explicit on_delete=models.CASCADE · f5869cb5
      Arkadiusz Hiler authored
      As it will be mandatory in future versions of django.
      Signed-off-by: default avatarArkadiusz Hiler <arkadiusz.hiler@intel.com>
    • Arkadiusz Hiler's avatar
      forms: Move definitions of fields that depend on runtime data to __init__ · ace98b24
      Arkadiusz Hiler authored
      Newer versions of django does not initialize models completely and this
      cause exception.
      Signed-off-by: default avatarArkadiusz Hiler <arkadiusz.hiler@intel.com>
    • Arkadiusz Hiler's avatar
      django-rest-framework: Update to 3.3 · f63f424e
      Arkadiusz Hiler authored
       * QUERY_PARAMS and DATA are now lower case
       * we set date format to ISO8601 in the ModelSerializer itself now, no
         need for subclassing
       * there is no WritableField anymore, just use Field
       * to_native and from_native got renamed to to_representation and
         to_internal_value respectively
       * dropped the field names from the field serializer instantiation if
         the data field is named the same as the python field
       * allow_none is now split into allow_blank and allow_null, so use both
       * serialized/validated data is now split into sub-dictionaries on dot,
         so use the new notation (e.g. f['a.b'] becomes f['a']['b'])
       * some error messages got changed, updated the tests to expect the new
       * is_valid_field() is now invoked on raw names, so we do not have to
         accommodate for the mapping introduced by the get_ordering()
       * dropped our own implementation of UpdateModelMixin in favor of the
         one provided by the framework, which additionally allowed us to get
         rid of a deprecated save hook
       * pagination configuration happens now by subclassing the page handling
      Signed-off-by: default avatarArkadiusz Hiler <arkadiusz.hiler@intel.com>
  4. 10 Nov, 2017 1 commit
    • Arkadiusz Hiler's avatar
      series: Disable "test [...] again" button when appropriate · 4a03e386
      Arkadiusz Hiler authored
      Move the button to a div container, so it can be disabled with an
      overlay with a tooltip.
      The button is now disabled if the user is not logged in or is not a
      maintainer of the project, with an appropriate tooltip explaining this.
      Also juggle fade_{enable,disable} functions so they are exported as a
      part of the pw object, so we can reuse them for disabling the
      before mentioned button.
      Signed-off-by: default avatarArkadiusz Hiler <arkadiusz.hiler@intel.com>
  5. 01 Nov, 2017 3 commits
    • Arkadiusz Hiler's avatar
      series: Add test latest revision again button · 337d9b47
      Arkadiusz Hiler authored
      Before, to rerun tests on a series, we had to go to series lists, search
      for it, select a checkbox and press the button.
      This is quality of life improvement that adds the button to the series
      page, so there's less hassle required.
      The button is blue, and when clicked it is disabled and turns yellow for
      the duration of request to the server, then turns either green, if the
      rerun was queued successfully, or red when the request has failed.
      Button's text also changes to reflect the current state.
      To re-enable the button (e.g. in unusual scenario of queueing two
      reruns) page needs to be refreshed.
      Signed-off-by: default avatarArkadiusz Hiler <arkadiusz.hiler@intel.com>
    • Arkadiusz Hiler's avatar
      series-list: Make the action buttons always visible · 9675dc6a
      Arkadiusz Hiler authored
      "Test again" and "set reviewers" buttons were hard to discover, because
      as a maintainer, you had to select some checkboxes, which resulted in
      filtering options being replaced with the action buttons.
      Now, the action buttons are always visible but grayed out, with helpful
      mouse hover tooltip explaining the requirements for them to be enabled.
      Signed-off-by: default avatarArkadiusz Hiler <arkadiusz.hiler@intel.com>
    • Arkadiusz Hiler's avatar
      series: Improve filtering UI · 70955d7e
      Arkadiusz Hiler authored
      Move "Filter by:" to the left, as "Status" is just a filter like the
      others, so it makes sense for them to be grouped together.
      So instead of:  Status     | Filter By: | Date | Submitter
      We have now:    Filter By: | Status     | Date | Submitter
      The "show all series" link changes its misleading name to "reset
      filters", as it restores filters to their default values (i.e. does not
      show series that are considered "done").
      Signed-off-by: default avatarArkadiusz Hiler <arkadiusz.hiler@intel.com>
  6. 31 Oct, 2017 1 commit
  7. 29 Oct, 2017 2 commits
    • Arkadiusz Hiler's avatar
      patch: Implement log events for pull requests · 8d3953ef
      Arkadiusz Hiler authored
      Add new event type, pull-request-new, for logging incoming pull
      This will allow CI systems to track PRs just as easily as regular
      The change also loosens up constraints imposed on EventLog model - it
      used to assume always having an associated series, which is not true for
      the pull requests. PRs are standalone patches.
      Signed-off-by: default avatarArkadiusz Hiler <arkadiusz.hiler@intel.com>
    • Arkadiusz Hiler's avatar
      pep8: Fix compatiblity with the newest revision · 1450948c
      Arkadiusz Hiler authored
      Rather crude attempt to make things silent again.
      patchwork/lock.py:232:13: E741 ambiguous variable name 'l'
      patchwork/filters.py:105:9: E722 do not use bare except'
      patchwork/filters.py:170:9: E722 do not use bare except'
      patchwork/filters.py:352:9: E722 do not use bare except'
      patchwork/models.py:344:9: E722 do not use bare except'
      patchwork/tests/browser.py:26:1: E722 do not use bare except'
      patchwork/tests/test_lock.py:68:9: E741 ambiguous variable name 'l'
      patchwork/bin/parsemail.py:852:5: E741 ambiguous variable name 'l'
      patchwork/bin/parsemail.py:857:5: E741 ambiguous variable name 'l'
      patchwork/bin/parsemail.py:884:5: E722 do not use bare except'
      patchwork/views/api.py:25:1: E722 do not use bare except'
      patchwork/views/bundle.py:76:17: E722 do not use bare except'
      patchwork/views/xmlrpc.py:95:9: E722 do not use bare except'
      patchwork/views/xmlrpc.py:127:9: E722 do not use bare except'
      patchwork/bin/pwclient:271:5: E722 do not use bare except'
      patchwork/bin/pwclient:279:5: E722 do not use bare except'
      patchwork/bin/pwclient:357:5: E722 do not use bare except'
      patchwork/bin/pwclient:549:9: E722 do not use bare except'
      patchwork/bin/pwclient:555:9: E722 do not use bare except'
      patchwork/bin/pwclient:600:9: E722 do not use bare except'
      patchwork/bin/pwclient:650:5: E722 do not use bare except'
      git-pw/git-pw:540:9: E722 do not use bare except'
      git-pw/git-pw:555:9: E722 do not use bare except'
      git-pw/git-pw:567:9: E722 do not use bare except'
      git-pw/git-pw:586:9: E722 do not use bare except'
      "except Exception" should be chosen more carefully.
      Signed-off-by: default avatarArkadiusz Hiler <arkadiusz.hiler@intel.com>
  8. 06 Oct, 2017 1 commit
  9. 05 Oct, 2017 1 commit
  10. 26 Sep, 2017 1 commit
  11. 04 Sep, 2017 2 commits
  12. 20 Aug, 2017 2 commits
    • Arkadiusz Hiler's avatar
      rest: Add GET support for test results endpoint · 1cb2039c
      Arkadiusz Hiler authored
      So far test results could be only posted via the REST API.
      This patch add GET verb support to the following endpoint
      /api/1.0/series/(int: series_id)/revisions/(int: version)/test-results/
      allowing clients to also query the results.
      Signed-off-by: default avatarArkadiusz Hiler <arkadiusz.hiler@intel.com>
    • Arkadiusz Hiler's avatar
      rest: Use "human name" for the series · deb22b51
      Arkadiusz Hiler authored
      Currently all series without a cover letter are visible both through the
      API and the web interface (which uses the API) as a
      "Series without cover letter".
      That makes the series hard to identify and takes a toll on developers'
      and maintainers' time.
      We already have means of generating friendlier titles in form
      "series starting with THE FIRST PATCH NAME"
      that was created for seeding out results,
      So let's reuse it in the API for consistency.
      Also bump query number in one of the related tests, became this patch
      introduces an additional one.
      Signed-off-by: default avatarArkadiusz Hiler <arkadiusz.hiler@intel.com>
  13. 08 Aug, 2017 1 commit
  14. 04 Aug, 2017 1 commit
  15. 27 Jul, 2017 2 commits
  16. 24 Jul, 2017 4 commits