1. 22 Oct, 2019 4 commits
  2. 30 May, 2018 1 commit
  3. 23 Jan, 2018 1 commit
  4. 15 Jan, 2018 1 commit
    • Arkadiusz Hiler's avatar
      urls: Use named URLs · 492485df
      Arkadiusz Hiler authored
      
      
      Using the quoted doted path to the view callable object
      (e.g. 'patchwork.views.projects') is going to be deprecated soon.
      Using either the actual callable or a named URL is recommended.
      
      Let future-proof urls.py by using the actual callables there and
      name all the URLs, so we can use the names everywhere else.
      Signed-off-by: default avatarArkadiusz Hiler <arkadiusz.hiler@intel.com>
      492485df
  5. 29 Oct, 2017 1 commit
    • Arkadiusz Hiler's avatar
      pep8: Fix compatiblity with the newest revision · 1450948c
      Arkadiusz Hiler authored
      
      
      Rather crude attempt to make things silent again.
      
      patchwork/lock.py:232:13: E741 ambiguous variable name 'l'
      patchwork/filters.py:105:9: E722 do not use bare except'
      patchwork/filters.py:170:9: E722 do not use bare except'
      patchwork/filters.py:352:9: E722 do not use bare except'
      patchwork/models.py:344:9: E722 do not use bare except'
      patchwork/tests/browser.py:26:1: E722 do not use bare except'
      patchwork/tests/test_lock.py:68:9: E741 ambiguous variable name 'l'
      patchwork/bin/parsemail.py:852:5: E741 ambiguous variable name 'l'
      patchwork/bin/parsemail.py:857:5: E741 ambiguous variable name 'l'
      patchwork/bin/parsemail.py:884:5: E722 do not use bare except'
      patchwork/views/api.py:25:1: E722 do not use bare except'
      patchwork/views/bundle.py:76:17: E722 do not use bare except'
      patchwork/views/xmlrpc.py:95:9: E722 do not use bare except'
      patchwork/views/xmlrpc.py:127:9: E722 do not use bare except'
      patchwork/bin/pwclient:271:5: E722 do not use bare except'
      patchwork/bin/pwclient:279:5: E722 do not use bare except'
      patchwork/bin/pwclient:357:5: E722 do not use bare except'
      patchwork/bin/pwclient:549:9: E722 do not use bare except'
      patchwork/bin/pwclient:555:9: E722 do not use bare except'
      patchwork/bin/pwclient:600:9: E722 do not use bare except'
      patchwork/bin/pwclient:650:5: E722 do not use bare except'
      git-pw/git-pw:540:9: E722 do not use bare except'
      git-pw/git-pw:555:9: E722 do not use bare except'
      git-pw/git-pw:567:9: E722 do not use bare except'
      git-pw/git-pw:586:9: E722 do not use bare except'
      
      "except Exception" should be chosen more carefully.
      Signed-off-by: default avatarArkadiusz Hiler <arkadiusz.hiler@intel.com>
      1450948c
  6. 10 Jul, 2017 1 commit
  7. 01 Apr, 2016 2 commits
  8. 15 Mar, 2016 1 commit
  9. 18 Feb, 2016 1 commit
  10. 17 Feb, 2016 2 commits
  11. 16 Feb, 2016 2 commits
  12. 05 Dec, 2015 6 commits
  13. 17 Sep, 2015 1 commit
  14. 27 May, 2015 1 commit
  15. 22 Mar, 2015 4 commits
  16. 06 May, 2014 1 commit
  17. 10 Jun, 2013 1 commit
  18. 30 Dec, 2012 1 commit
    • Douglas Anderson's avatar
      xmlrpc: Avoid trying to marshall None for people with no name · 6dede3e0
      Douglas Anderson authored
      
      
      If a person sent patches with no real name, they may have None for
      their name.  In this case just use their email address as their name.
      
      The previous pwclient error that would show up looks like:
      
        $ pwclient list -w anonymous@example.com
        Traceback (most recent call last):
          File ".../pwclient", line 631, in <module>
            main()
          File ".../pwclient", line 570, in main
            action_list(rpc, filt, submitter_str, delegate_str, series_str)
          File ".../pwclient", line 316, in action_list
            ids = person_ids_by_name(rpc, submitter_str)
          File ".../pwclient", line 241, in person_ids_by_name
            people = rpc.person_list(name, 0)
          File "/usr/lib/python2.7/xmlrpclib.py", line 1224, in __call__
            return self.__send(self.__name, args)
          File "/usr/lib/python2.7/xmlrpclib.py", line 1578, in __request
            verbose=self.__verbose
          File "/usr/lib/python2.7/xmlrpclib.py", line 1264, in request
            return self.single_request(host, handler, request_body, verbose)
          File "/usr/lib/python2.7/xmlrpclib.py", line 1297, in single_request
            return self.parse_response(response)
          File "/usr/lib/python2.7/xmlrpclib.py", line 1473, in parse_response
            return u.close()
          File "/usr/lib/python2.7/xmlrpclib.py", line 793, in close
            raise Fault(**self._stack[0])
        xmlrpclib.Fault: <Fault 1: "<type 'exceptions.TypeError'>:cannot marshal None unless allow_none is enabled">
      Signed-off-by: Douglas Anderson's avatarDoug Anderson <dianders@chromium.org>
      Signed-off-by: default avatarJeremy Kerr <jk@ozlabs.org>
      6dede3e0
  19. 18 Jul, 2011 1 commit
    • Jeremy Kerr's avatar
      xmlrpc: do slice before patch_to_dict · 539b6596
      Jeremy Kerr authored
      
      
      Currently, we map patch_to_dict before we slice the results (to only
      return max_count patches). This means that we hacve to retrieve all
      patches, then throw away most of the results of the map.
      
      This change does the slice on the patches before the map, letting django
      do a LIMIT-ed query instead.
      Signed-off-by: default avatarJeremy Kerr <jk@ozlabs.org>
      539b6596
  20. 30 Mar, 2011 2 commits
  21. 15 Mar, 2011 1 commit
  22. 11 Feb, 2011 1 commit
  23. 10 Aug, 2010 1 commit
    • Jeremy Kerr's avatar
      views: implement CSRF protection · 5b984a02
      Jeremy Kerr authored
      
      
      Since we've got the csrf token present, we may as well check it for
      requests.
      
      We're using RequestContext already (via PatchworkRequestContext), so we
      just need to switch it on in the settings, and add an exemption on the
      xmlrpc interface.
      Signed-off-by: default avatarJeremy Kerr <jk@ozlabs.org>
      5b984a02
  24. 22 Oct, 2009 1 commit
    • Jeremy Kerr's avatar
      pwclient,xmlrpc: Specify project for patch hash lookups · 7bcba313
      Jeremy Kerr authored
      
      
      We may see the same hash for two patches if one is sent to two lists
      tracked by patchwork.
      
      This change adds a new xmlrpc method, patch_get_by_project_hash, which
      adds the linkname parameter to the lookup. We need to add a new method
      instead of replacing patch_get_by_hash, to avoid breaking existing
      pwclient apps.
      Signed-off-by: default avatarJeremy Kerr <jk@ozlabs.org>
      7bcba313
  25. 15 Aug, 2009 1 commit