Commit 87dc9ee0 authored by Arkadiusz Hiler's avatar Arkadiusz Hiler Committed by Arkadiusz Hiler
Browse files

comment: Add 'Fixes:' to recognized tags

'Fixes:' is common tag added in the comments, so we should automatically
pick it up too.

Also add an unit test to make sure we don't break this in the future.
Signed-off-by: default avatarArkadiusz Hiler <>
parent 978434e3
......@@ -405,7 +405,7 @@ class Comment(models.Model):
content = models.TextField()
response_re = re.compile(
'^(Tested|Reviewed|Acked|Signed-off|Nacked|Reported)-by: .*$',
'^((Tested|Reviewed|Acked|Signed-off|Nacked|Reported)-by|Fixes): .*$',
re.M | re.I)
def patch_responses(self):
# Patchwork - automated patch tracking system
# Copyright (C) 2017 Intel Corporation
# This file is part of the Patchwork package.
# Patchwork is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
# Patchwork is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# GNU General Public License for more details.
# You should have received a copy of the GNU General Public License
# along with Patchwork; if not, write to the Free Software
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
from django.test import TestCase
from patchwork.models import Comment
Hey, hi, hello
Nonsense-by: zzz
TAGS = \
Reviewed-by: aaa
Fixes: foo
Signed-off-by: bbb
Acked-by: bar
Tested-by: ccc
Nacked-by: baz
Reported-by: ddd
class CommentTest(TestCase):
def testPatchResponse(self):
comment = Comment()
comment.content = NOT_TAGS + TAGS
reference_tags = TAGS.split()
actual_tags = comment.patch_responses().split()
self.assertListEqual(sorted(reference_tags), sorted(actual_tags))
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment