Commit 628a57c2 authored by Jeremy Kerr's avatar Jeremy Kerr
Browse files

Fix django-1.6 incompatibilities

We're seeing a couple of final quirks running the testsuite on django

  Traceback (most recent call last):
    File "patchwork/apps/patchwork/tests/", line 182, in testNotificationEscaping
      errors = send_notifications()
    File "patchwork/apps/patchwork/", line 227, in send_notifications
    File "patchwork/apps/patchwork/", line 197, in delete_notifications
      pk__in = notifications).delete()
    File "/usr/lib/python2.7/dist-packages/django/db/models/", line 163, in filter
      return self.get_queryset().filter(*args, **kwargs)
    File "/usr/lib/python2.7/dist-packages/django/db/models/", line 590, in filter
      return self._filter_or_exclude(False, *args, **kwargs)
    File "/usr/lib/python2.7/dist-packages/django/db/models/", line 608, in _filter_or_exclude
      clone.query.add_q(Q(*args, **kwargs))
    File "/usr/lib/python2.7/dist-packages/django/db/models/sql/", line 1198, in add_q
      clause = self._add_q(where_part, used_aliases)
    File "/usr/lib/python2.7/dist-packages/django/db/models/sql/", line 1232, in _add_q
    File "/usr/lib/python2.7/dist-packages/django/db/models/sql/", line 1122, in build_filter
      lookup_type, value)
    File "/usr/lib/python2.7/dist-packages/django/db/models/fields/", line 1107, in get_lookup_constraint
      values = [get_normalized_value(value) for value in raw_value]
    File "/usr/lib/python2.7/dist-packages/django/db/models/fields/", line 1084, in get_normalized_value
      value_list.append(getattr(value, source.attname))
  AttributeError: 'PatchChangeNotification' object has no attribute 'id'

- we're specifying our own pk here, so the PatchChangeNotification has
no id attribute; it looks like the pk__in syntax is expecting IDs.

We also need a default value for BooleanField, as we're getting
integrity errors when creating rows with no explicit send_notifications
Signed-off-by: default avatarJeremy Kerr <>
parent b8c32a2f
......@@ -55,7 +55,7 @@ class Project(models.Model):
web_url = models.CharField(max_length=2000, blank=True)
scm_url = models.CharField(max_length=2000, blank=True)
webscm_url = models.CharField(max_length=2000, blank=True)
send_notifications = models.BooleanField()
send_notifications = models.BooleanField(default=False)
def __unicode__(self):
......@@ -191,8 +191,8 @@ def send_notifications():
projects = set([ n.patch.project.linkname for n in notifications ])
def delete_notifications():
pk__in = notifications).delete()
pks = [ for n in notifications ]
PatchChangeNotification.objects.filter(pk__in = pks).delete()
if EmailOptout.is_optout(
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment