Commit a3b85599 authored by Alyssa Rosenzweig's avatar Alyssa Rosenzweig 💜

Debug issue with off-by-one in height

parent a70a4a34
......@@ -89,8 +89,6 @@ trans_invalidate_frame(struct panfrost_context *ctx)
for (int i = 0; i <= PIPE_SHADER_FRAGMENT; ++i)
ctx->constant_buffer[i].dirty = true;
trans_set_framebuffer_msaa(ctx, true);
}
/* Framebuffer descriptor */
......@@ -127,10 +125,7 @@ trans_new_frag_framebuffer(struct panfrost_context *ctx)
{
struct mali_single_framebuffer fb = trans_emit_fbd(ctx);
/* It's unclear what function the off-by-one serves here, unless I just
* botched the calculation */
fb.framebuffer_end = ctx->framebuffer.gpu + ctx->width * (ctx->height + 1) * 4;
fb.framebuffer_end = ctx->framebuffer.gpu + ctx->framebuffer.size;
fb.unknown2 = 0xb84e0281;
fb.unknown10 = 0xfffff9c0;
......@@ -1280,6 +1275,7 @@ trans_setup_framebuffer(struct panfrost_context *ctx)
pandev_ioctl(ctx->fd, MALI_IOCTL_MEM_IMPORT, &framebuffer_import);
ctx->framebuffer.gpu = framebuffer_import.gpu_va;
ctx->framebuffer.size = framebuffer_sz;
}
static void
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment