1. 18 Sep, 2012 3 commits
    • Brian Paul's avatar
      mesa: move/fix levels check for glTexStorage() · 7dc76e94
      Brian Paul authored
      Fix copy&paste error and move min levels check closer to max levels check.
      Reviewed-by: Jose Fonseca's avatarJose Fonseca <jfonseca@vmware.com>
      7dc76e94
    • Brian Paul's avatar
      mesa: rewrite glTexStorage() code · ff24ed09
      Brian Paul authored
      Simplify the code and make it more like the other glTexImage commands.
      Call _mesa_legal_texture_dimensions() to validate width, height, depth.
      Call ctx->Driver.TestProxyTexImage() to make sure texture is not too large.
      Reviewed-by: Jose Fonseca's avatarJose Fonseca <jfonseca@vmware.com>
      ff24ed09
    • Brian Paul's avatar
      mesa: rework texture size error checking · e6eaa85a
      Brian Paul authored
      There are two aspects to texture image size checking:
      1. Are the width, height, depth legal values (not negative, not larger
         than the max size for the mipmap level, etc)?
      2. Is the texture just too large to handle?  For example, we might not be
         able to really allocate memory for a 3D texture of maxSize x maxSize x
         maxSize.
      
      Previously, we did (1) via the ctx->Driver.TestProxyTextureImage() hook
      but those tests are really device-independent.  Now we do (2) via that
      hook since the max texture memory and texture shape are device-dependent.
      
      Also, (1) is now done outside the general texture parameter error checking
      functions because of the special interaction with proxy textures.  The
      recently introduced PROXY_ERROR token is removed.
      
      The teximage() and copyteximage() functions are bit simpler now (less
      if-then nesting, etc.)
      Reviewed-by: Jose Fonseca's avatarJose Fonseca <jfonseca@vmware.com>
      e6eaa85a
  2. 11 Sep, 2012 2 commits
    • Brian Paul's avatar
      mesa: fix proxy texture error handling in glTexStorage() · 35c75f67
      Brian Paul authored
      This is basically a follow-on to 1f5b1f98.
      Basically, generate GL errors for ordinary invalid parameters for proxy
      targets the same as for non-proxy targets.  Only texture size and OOM
      errors should be handled specially for proxies.
      
      Note: This is a candidate for the stable branches.
      35c75f67
    • Brian Paul's avatar
      mesa: do internal format error checking for glTexStorage() · 2e4fc549
      Brian Paul authored
      Turns out we weren't doing any format checking before.  Now check
      the internal format and, in particular, make sure that unsized internal
      formats aren't accepted.
      
      Note: This is a candidate for the stable branches.
      2e4fc549
  3. 24 Aug, 2012 1 commit
  4. 04 Jan, 2012 1 commit
  5. 31 Oct, 2011 1 commit