1. 18 Jan, 2019 2 commits
  2. 15 Jan, 2019 1 commit
    • Linus Walleij's avatar
      mtd: rawnand: fsmc: Keep bank enable bit set · 663ec3a2
      Linus Walleij authored
      Hammering the "bank enable" (PBKEN) bit on and off between
      every command crashes the Nomadik NHK15 with this message:
      
      Scanning device for bad blocks
      Unhandled fault: external abort on non-linefetch (0x008) at 0xcc95e000
      pgd = (ptrval)
      [cc95e000] *pgd=0b808811, *pte=40000653, *ppte=40000552
      Internal error: : 8 [#1] PREEMPT ARM
      Modules linked in:
      CPU: 0 PID: 1 Comm: swapper Not tainted 4.20.0-rc2+ #72
      Hardware name: Nomadik STn8815
      PC is at fsmc_exec_op+0x194/0x204
      (...)
      
      After a discussion we (me and Boris Brezillon) start to suspect
      that this bit does not immediately control the chip select line
      at all, it rather enables access to the bank and the hardware
      will drive the CS autonomously. If there is a NAND chip connected,
      we should keep this enabled.
      
      As fsmc_nand_setup() sets this bit, we can simply remove the
      offending code.
      
      Fixes: 550b9fc4 ("mtd: rawnand: fsmc: Stop implementing ->select_chip()")
      Signed-off-by: Linus Walleij's avatarLinus Walleij <linus.walleij@linaro.org>
      Acked-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
      Signed-off-by: default avatarBoris Brezillon <bbrezillon@kernel.org>
      663ec3a2
  3. 13 Jan, 2019 1 commit
  4. 11 Jan, 2019 11 commits
  5. 10 Jan, 2019 13 commits
  6. 09 Jan, 2019 12 commits