1. 10 Dec, 2018 1 commit
  2. 16 Mar, 2018 2 commits
  3. 14 Nov, 2017 2 commits
  4. 02 Nov, 2017 1 commit
    • Greg Kroah-Hartman's avatar
      License cleanup: add SPDX GPL-2.0 license identifier to files with no license · b2441318
      Greg Kroah-Hartman authored
      Many source files in the tree are missing licensing information, which
      makes it harder for compliance tools to determine the correct license.
      By default all files without license information are under the default
      license of the kernel, which is GPL version 2.
      Update the files which contain no license information with the 'GPL-2.0'
      SPDX license identifier.  The SPDX identifier is a legally binding
      shorthand, which can be used instead of the full boiler plate text.
      This patch is based on work done by Thomas Gleixner and Kate Stewart and
      Philippe Ombredanne.
      How this work was done:
      Patches were generated and checked against linux-4.14-rc6 for a subset of
      the use cases:
       - file had no licensing information it it.
       - file was a */uapi/* one with no licensing information in it,
       - file was a */uapi/* one with existing licensing information,
      Further patches will be generated in subsequent months to fix up cases
      where non-standard license headers were used, and references to license
      had to be inferred by heuristics based on keywords.
      The analysis to determine which SPDX License Identifier to be applied to
      a file was done in a spreadsheet of side by side results from of the
      output of two independent scanners (ScanCode & Windriver) producing SPDX
      tag:value files created by Philippe Ombredanne.  Philippe prepared the
      base worksheet, and did an initial spot review of a few 1000 files.
      The 4.13 kernel was the starting point of the analysis with 60,537 files
      assessed.  Kate Stewart did a file by file comparison of the scanner
      results in the spreadsheet to determine which SPDX license identifier(s)
      to be applied to the file. She confirmed any determination that was not
      immediately clear with lawyers working with the Linux Foundation.
      Criteria used to select files for SPDX license identifier tagging was:
       - Files considered eligible had to be source code files.
       - Make and config files were included as candidates if they contained >5
         lines of source
       - File already had some variant of a license header in it (even if <5
      All documentation files were explicitly excluded.
      The following heuristics were used to determine which SPDX license
      identifiers to apply.
       - when both scanners couldn't find any license traces, file was
         considered to have no license information in it, and the top level
         COPYING file license applied.
         For non */uapi/* files that summary was:
         SPDX license identifier                            # files
         GPL-2.0                                              11139
         and resulted in the first patch in this series.
         If that file was a */uapi/* path one, it was "GPL-2.0 WITH
         Linux-syscall-note" otherwise it was "GPL-2.0".  Results of that was:
         SPDX license identifier                            # files
         GPL-2.0 WITH Linux-syscall-note                        930
         and resulted in the second patch in this series.
       - if a file had some form of licensing information in it, and was one
         of the */uapi/* ones, it was denoted with the Linux-syscall-note if
         any GPL family license was found in the file or had no licensing in
         it (per prior point).  Results summary:
         SPDX license identifier                            # files
         GPL-2.0 WITH Linux-syscall-note                       270
         GPL-2.0+ WITH Linux-syscall-note                      169
         ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause)    21
         ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause)    17
         LGPL-2.1+ WITH Linux-syscall-note                      15
         GPL-1.0+ WITH Linux-syscall-note                       14
         ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause)    5
         LGPL-2.0+ WITH Linux-syscall-note                       4
         LGPL-2.1 WITH Linux-syscall-note                        3
         ((GPL-2.0 WITH Linux-syscall-note) OR MIT)              3
         ((GPL-2.0 WITH Linux-syscall-note) AND MIT)             1
         and that resulted in the third patch in this series.
       - when the two scanners agreed on the detected license(s), that became
         the concluded license(s).
       - when there was disagreement between the two scanners (one detected a
         license but the other didn't, or they both detected different
         licenses) a manual inspection of the file occurred.
       - In most cases a manual inspection of the information in the file
         resulted in a clear resolution of the license that should apply (and
         which scanner probably needed to revisit its heuristics).
       - When it was not immediately clear, the license identifier was
         confirmed with lawyers working with the Linux Foundation.
       - If there was any question as to the appropriate license identifier,
         the file was flagged for further research and to be revisited later
         in time.
      In total, over 70 hours of logged manual review was done on the
      spreadsheet to determine the SPDX license identifiers to apply to the
      source files by Kate, Philippe, Thomas and, in some cases, confirmation
      by lawyers working with the Linux Foundation.
      Kate also obtained a third independent scan of the 4.13 code base from
      FOSSology, and compared selected files where the other two scanners
      disagreed against that SPDX file, to see if there was new insights.  The
      Windriver scanner is based on an older version of FOSSology in part, so
      they are related.
      Thomas did random spot checks in about 500 files from the spreadsheets
      for the uapi headers and agreed with SPDX license identifier in the
      files he inspected. For the non-uapi files Thomas did random spot checks
      in about 15000 files.
      In initial set of patches against 4.14-rc6, 3 files were found to have
      copy/paste license identifier errors, and have been fixed to reflect the
      correct identifier.
      Additionally Philippe spent 10 hours this week doing a detailed manual
      inspection and review of the 12,461 patched files from the initial patch
      version early this week with:
       - a full scancode scan run, collecting the matched texts, detected
         license ids and scores
       - reviewing anything where there was a license detected (about 500+
         files) to ensure that the applied SPDX license was correct
       - reviewing anything where there was no detection but the patch license
         was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
         SPDX license was correct
      This produced a worksheet with 20 files needing minor correction.  This
      worksheet was then exported into 3 different .csv files for the
      different types of files to be modified.
      These .csv files were then reviewed by Greg.  Thomas wrote a script to
      parse the csv files and add the proper SPDX tag to the file, in the
      format that the file expected.  This script was further refined by Greg
      based on the output to detect more types of files automatically and to
      distinguish between header and source .c files (which need different
      comment types.)  Finally Greg ran the script using the .csv files to
      generate the patches.
      Reviewed-by: default avatarKate Stewart <kstewart@linuxfoundation.org>
      Reviewed-by: default avatarPhilippe Ombredanne <pombredanne@nexb.com>
      Reviewed-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
  5. 31 Aug, 2017 1 commit
  6. 02 Jun, 2017 1 commit
  7. 07 Apr, 2017 1 commit
    • Linus Walleij's avatar
      ARM/clk: move the ICST library to drivers/clk · ba3fae06
      Linus Walleij authored
      This moves the ICST clock divider helper library from
      arch/arm/common to drivers/clk/versatile so it is maintained
      with the other clock drivers.
      We keep the structure as a helper library intact and do not
      fuse it with the clk-icst.c Versatile ICST clock driver: there
      may be other users out there that need to use this library for
      their clocking, and then it will be helpful to keep the
      library contained. (The icst.[c|h] files could just be moved
      to drivers/clk/lib or a similar location to share the library.)
      Acked-by: default avatarStephen Boyd <sboyd@codeaurora.org>
      Signed-off-by: Linus Walleij's avatarLinus Walleij <linus.walleij@linaro.org>
  8. 29 Aug, 2016 1 commit
  9. 25 Aug, 2016 1 commit
    • Linus Walleij's avatar
      clk: versatile/icst: add Integrator core module clocks · 5e23c593
      Linus Walleij authored
      The Integrator/AP and Integrator/CP have special derivatives
      of the ICST525 control registers, where some bits have been
      hardwired but others are possible to adjust, resulting in a
      control register that makes it possible to set an even,
      desired megahertz value.
      The Integrator/AP and Integrator/CP have slightly different
      layout so we support them using different compatible
      After adding these clocks, the Integrator-specific cpufreq
      driver can be switched over to use the generic operating
      point device tree cpufreq driver.
      Instead of simply writing a value to the oscillator control
      register we switch to the more elaborate method of providing
      a bitmask and use regmap_update_bits() to poke the right bits
      for the desired frequency, this is needed since these control
      registers sometimes control more than one clock.
      Cc: Russell King <linux@armlinux.org.uk>
      Signed-off-by: Linus Walleij's avatarLinus Walleij <linus.walleij@linaro.org>
      Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
  10. 15 Mar, 2016 1 commit
  11. 25 Feb, 2016 1 commit
    • Linus Walleij's avatar
      clk: versatile: sp810: support reentrance · ec7957a6
      Linus Walleij authored
      Despite care take to allocate clocks state containers the
      SP810 driver actually just supports creating one instance:
      all clocks registered for every instance will end up with the
      exact same name and __clk_init() will fail.
      Rename the timclken<0> .. timclken<n> to sp810_<instance>_<n>
      so every clock on every instance gets a unique name.
      This is necessary for the RealView PBA8 which has two SP810
      blocks: the second block will not register its clocks unless
      every clock on every instance is unique and results in boot
      logs like this:
      ------------[ cut here ]------------
      WARNING: CPU: 0 PID: 0 at ../drivers/clk/versatile/clk-sp810.c:137
      Modules linked in:
      CPU: 0 PID: 0 Comm: swapper/0 Not tainted
      4.5.0-rc2-00030-g352718fc39f6-dirty #225
      Hardware name: ARM RealView Machine (Device Tree Support)
      [<c00167f8>] (unwind_backtrace) from [<c0013204>]
      [<c0013204>] (show_stack) from [<c01a049c>]
      [<c01a049c>] (dump_stack) from [<c0024990>]
      [<c0024990>] (warn_slowpath_common) from [<c0024a68>]
      [<c0024a68>] (warn_slowpath_null) from [<c051eb44>]
      [<c051eb44>] (clk_sp810_of_setup) from [<c051e3a4>]
      [<c051e3a4>] (of_clk_init) from [<c0504714>]
      [<c0504714>] (time_init) from [<c0501b18>]
      [<c0501b18>] (start_kernel) from [<7000807c>] (0x7000807c)
      ---[ end trace cb88537fdc8fa200 ]---
      Cc: Michael Turquette <mturquette@baylibre.com>
      Cc: Pawel Moll <pawel.moll@arm.com>
      Fixes: 6e973d2c "clk: vexpress: Add separate SP810 driver"
      Signed-off-by: Linus Walleij's avatarLinus Walleij <linus.walleij@linaro.org>
      Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
  12. 10 Feb, 2016 1 commit
    • Linus Walleij's avatar
      clk: versatile: mask VCO bits before writing · df9cd564
      Linus Walleij authored
      The Versatile syscon ICST driver OR:s the bits into place but
      forgets to mask the previous value, making the code only work
      if the register is zero or giving haphazard results. Mask the
      19 bits used by the Versatile syscon interface register.
      Regression caused and now fixed by yours truly.
      Cc: Michael Turquette <mturquette@baylibre.com>
      Cc: Stephen Boyd <sboyd@codeaurora.org>
      Cc: linux-clk@vger.kernel.org
      Fixes: 179c8fb3 ("clk: versatile-icst: convert to use regmap")
      Signed-off-by: Linus Walleij's avatarLinus Walleij <linus.walleij@linaro.org>
      Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
  13. 15 Dec, 2015 5 commits
  14. 20 Nov, 2015 1 commit
  15. 18 Nov, 2015 1 commit
  16. 23 Oct, 2015 1 commit
  17. 16 Oct, 2015 1 commit
  18. 24 Aug, 2015 2 commits
  19. 29 Jul, 2015 1 commit
  20. 20 Jul, 2015 1 commit
  21. 15 May, 2015 1 commit
    • Stephen Boyd's avatar
      clk: versatile: Silence sparse warnings · 11bee5e1
      Stephen Boyd authored
      drivers/clk/versatile/clk-sp810.c:159:29: error: incompatible types for operation (<=)
      drivers/clk/versatile/clk-sp810.c:159:29:    left side has type char const *<noident>
      drivers/clk/versatile/clk-sp810.c:159:29:    right side has type int
      drivers/clk/versatile/clk-sp810.c:159:53: error: incompatible types for operation (<=)
      drivers/clk/versatile/clk-sp810.c:159:53:    left side has type char const *<noident>
      drivers/clk/versatile/clk-sp810.c:159:53:    right side has type int
      drivers/clk/versatile/clk-sp810.c:138:13: warning: symbol 'clk_sp810_of_setup' was not declared. Should it be static?
      Acked: Pawel Moll <pawel.moll@arm.com>
      Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
  22. 09 Apr, 2015 1 commit
  23. 01 Apr, 2015 1 commit
  24. 28 Nov, 2014 1 commit
  25. 24 Jun, 2014 1 commit
  26. 31 May, 2014 1 commit
  27. 21 May, 2014 1 commit
  28. 15 May, 2014 3 commits
    • Pawel Moll's avatar
      clk: versatile: Split config options for sp810 and vexpress_osc · 5ee2b877
      Pawel Moll authored
      Move the Kconfig entry for Versatile (& Express) clock drivers
      into a separate file and add individual options for sp810
      and vexpress_osc drivers, as they are optional in some
      configurations and may have separate dependencies.
      Signed-off-by: default avatarPawel Moll <pawel.moll@arm.com>
      Acked-by: default avatarMike Turquette <mturquette@linaro.org>
    • Pawel Moll's avatar
      mfd: vexpress: Convert custom func API to regmap · 3b9334ac
      Pawel Moll authored
      Components of the Versatile Express platform (configuration
      microcontrollers on motherboard and daughterboards in particular)
      talk to each other over a custom configuration bus. They
      provide miscellaneous functions (from clock generator control
      to energy sensors) which are represented as platform devices
      (and Device Tree nodes). The transactions on the bus can
      be generated by different "bridges" in the system, some
      of which are universal for the whole platform (for the price
      of high transfer latencies), others restricted to a subsystem
      (but much faster).
      Until now drivers for such functions were using custom "func"
      API, which is being replaced in this patch by regmap calls.
      This required:
      * a rework (and move to drivers/bus directory, as suggested
        by Samuel and Arnd) of the config bus core, which is much
        simpler now and uses device model infrastructure (class)
        to keep track of the bridges; non-DT case (soon to be
        retired anyway) is simply covered by a special device
        registration function
      * the new config-bus driver also takes over device population,
        so there is no need for special matching table for
        of_platform_populate nor "simple-bus" hack in the arm64
        model dtsi file (relevant bindings documentation has
        been updated); this allows all the vexpress devices
        fit into normal device model, making it possible
        to remove plenty of early inits and other hacks in
        the near future
      * adaptation of the syscfg bridge implementation in the
        sysreg driver, again making it much simpler; there is
        a special case of the "energy" function spanning two
        registers, where they should be both defined in the tree
        now, but backward compatibility is maintained in the code
      * modification of the relevant drivers:
        * hwmon - just a straight-forward API change
        * power/reset driver - API change
        * regulator - API change plus error handling
        * osc clock driver - this one required larger rework
          in order to turn in into a standard platform driver
      Signed-off-by: default avatarPawel Moll <pawel.moll@arm.com>
      Acked-by: default avatarMark Brown <broonie@linaro.org>
      Acked-by: default avatarLee Jones <lee.jones@linaro.org>
      Acked-by: default avatarGuenter Roeck <linux@roeck-us.net>
      Acked-by: default avatarMike Turquette <mturquette@linaro.org>
    • Arnd Bergmann's avatar
      clk/versatile: export symbols for impd1 · a218d7fa
      Arnd Bergmann authored
      The impd1 code on mach-integrator can be a loadable module,
      so we have to export icst_clk_register, integrator_impd1_clk_init
      and integrator_impd1_clk_exit.
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Acked-by: Linus Walleij's avatarLinus Walleij <linus.walleij@linaro.org>
      Signed-off-by: default avatarMike Turquette <mturquette@linaro.org>
  29. 04 May, 2014 1 commit
  30. 24 Apr, 2014 1 commit
  31. 26 Feb, 2014 1 commit
    • Linus Walleij's avatar
      ARM: integrator: localize the impd1.h header · cc0cc4ca
      Linus Walleij authored
      As we move toward multiplatform support for the Integrator family
      we need to localize all <mach/*> headers. This moves the impd1.h
      header down to the machine folder, copying the the three defines
      only used by the clock driver down into the clock driver.
      Cc: Will Deacon <will.deacon@arm.com>
      Cc: Jonathan Austin <jonathan.austin@arm.com>
      Cc: Russell King <linux@arm.linux.org.uk>
      Cc: Mike Turquette <mturquette@linaro.org>
      Signed-off-by: Linus Walleij's avatarLinus Walleij <linus.walleij@linaro.org>