1. 10 Dec, 2018 1 commit
    • Stephen Boyd's avatar
      clk: hisilicon: Remove usage of CLK_IS_BASIC · 5a727ff6
      Stephen Boyd authored
      This flag doesn't look to be used by any code, just set in various clk
      init structures and then never tested again. Remove it from these
      drivers as it doesn't provide any benefit.
      
      Cc: Jiancheng Xue <xuejiancheng@hisilicon.com>
      Cc: Leo Yan <leo.yan@linaro.org>
      Cc: Jianguo Sun <sunjianguo1@huawei.com>
      Cc: Wei Yongjun <weiyongjun1@huawei.com>
      Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
      5a727ff6
  2. 16 Oct, 2018 1 commit
  3. 31 Aug, 2018 1 commit
  4. 01 Jun, 2018 1 commit
    • Daniel Lezcano's avatar
      clk/driver/hisi: Consolidate the Kconfig for the CLOCK_STUB · 7b873e4b
      Daniel Lezcano authored
      The current defconfig is inconsistent as it selects the mailbox and
      the clock for the hi6220 and the hi3660 without having their Kconfigs
      making sure the dependencies are correct. It ends up when selecting
      different versions for the kernel (for example when git bisecting)
      those options disappear and they don't get back, leading to unexpected
      behaviors. In our case, the cpufreq driver does no longer work because
      the clock fails to initialize due to the clock stub and the mailbox
      missing.
      
      In order to have the dependencies correctly set when defaulting, let's
      do the same as commit 3a49afb8 ("clk: enable hi655x common clk
      automatically") where we select automatically the driver when the
      parent driver is selected. With sensible defaults in place, we can leave
      other choices for EXPERT.
      Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
      Signed-off-by: default avatarLeo Yan <leo.yan@linaro.org>
      Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
      7b873e4b
  5. 15 May, 2018 1 commit
  6. 20 Mar, 2018 1 commit
  7. 16 Mar, 2018 1 commit
  8. 14 Mar, 2018 1 commit
    • Stephen Boyd's avatar
      clk: hisilicon: Mark phase_ops static · a91f77ef
      Stephen Boyd authored
      Sparse rightfully complains:
      
      drivers/clk/hisilicon/clk-hisi-phase.c:88:22: warning: symbol 'clk_phase_ops' was not declared. Should it be static?
      drivers/clk/hisilicon/clk-hisi-phase.c:88:22: warning: symbol 'clk_phase_ops' was not declared. Should it be static?
      Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
      a91f77ef
  9. 12 Mar, 2018 3 commits
  10. 27 Feb, 2018 5 commits
  11. 28 Dec, 2017 1 commit
  12. 07 Dec, 2017 1 commit
  13. 14 Nov, 2017 3 commits
  14. 02 Nov, 2017 2 commits
    • Greg Kroah-Hartman's avatar
      License cleanup: add SPDX GPL-2.0 license identifier to files with no license · b2441318
      Greg Kroah-Hartman authored
      Many source files in the tree are missing licensing information, which
      makes it harder for compliance tools to determine the correct license.
      
      By default all files without license information are under the default
      license of the kernel, which is GPL version 2.
      
      Update the files which contain no license information with the 'GPL-2.0'
      SPDX license identifier.  The SPDX identifier is a legally binding
      shorthand, which can be used instead of the full boiler plate text.
      
      This patch is based on work done by Thomas Gleixner and Kate Stewart and
      Philippe Ombredanne.
      
      How this work was done:
      
      Patches were generated and checked against linux-4.14-rc6 for a subset of
      the use cases:
       - file had no licensing information it it.
       - file was a */uapi/* one with no licensing information in it,
       - file was a */uapi/* one with existing licensing information,
      
      Further patches will be generated in subsequent months to fix up cases
      where non-standard license headers were used, and references to license
      had to be inferred by heuristics based on keywords.
      
      The analysis to determine which SPDX License Identifier to be applied to
      a file was done in a spreadsheet of side by side results from of the
      output of two independent scanners (ScanCode & Windriver) producing SPDX
      tag:value files created by Philippe Ombredanne.  Philippe prepared the
      base worksheet, and did an initial spot review of a few 1000 files.
      
      The 4.13 kernel was the starting point of the analysis with 60,537 files
      assessed.  Kate Stewart did a file by file comparison of the scanner
      results in the spreadsheet to determine which SPDX license identifier(s)
      to be applied to the file. She confirmed any determination that was not
      immediately clear with lawyers working with the Linux Foundation.
      
      Criteria used to select files for SPDX license identifier tagging was:
       - Files considered eligible had to be source code files.
       - Make and config files were included as candidates if they contained >5
         lines of source
       - File already had some variant of a license header in it (even if <5
         lines).
      
      All documentation files were explicitly excluded.
      
      The following heuristics were used to determine which SPDX license
      identifiers to apply.
      
       - when both scanners couldn't find any license traces, file was
         considered to have no license information in it, and the top level
         COPYING file license applied.
      
         For non */uapi/* files that summary was:
      
         SPDX license identifier                            # files
         ---------------------------------------------------|-------
         GPL-2.0                                              11139
      
         and resulted in the first patch in this series.
      
         If that file was a */uapi/* path one, it was "GPL-2.0 WITH
         Linux-syscall-note" otherwise it was "GPL-2.0".  Results of that was:
      
         SPDX license identifier                            # files
         ---------------------------------------------------|-------
         GPL-2.0 WITH Linux-syscall-note                        930
      
         and resulted in the second patch in this series.
      
       - if a file had some form of licensing information in it, and was one
         of the */uapi/* ones, it was denoted with the Linux-syscall-note if
         any GPL family license was found in the file or had no licensing in
         it (per prior point).  Results summary:
      
         SPDX license identifier                            # files
         ---------------------------------------------------|------
         GPL-2.0 WITH Linux-syscall-note                       270
         GPL-2.0+ WITH Linux-syscall-note                      169
         ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause)    21
         ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause)    17
         LGPL-2.1+ WITH Linux-syscall-note                      15
         GPL-1.0+ WITH Linux-syscall-note                       14
         ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause)    5
         LGPL-2.0+ WITH Linux-syscall-note                       4
         LGPL-2.1 WITH Linux-syscall-note                        3
         ((GPL-2.0 WITH Linux-syscall-note) OR MIT)              3
         ((GPL-2.0 WITH Linux-syscall-note) AND MIT)             1
      
         and that resulted in the third patch in this series.
      
       - when the two scanners agreed on the detected license(s), that became
         the concluded license(s).
      
       - when there was disagreement between the two scanners (one detected a
         license but the other didn't, or they both detected different
         licenses) a manual inspection of the file occurred.
      
       - In most cases a manual inspection of the information in the file
         resulted in a clear resolution of the license that should apply (and
         which scanner probably needed to revisit its heuristics).
      
       - When it was not immediately clear, the license identifier was
         confirmed with lawyers working with the Linux Foundation.
      
       - If there was any question as to the appropriate license identifier,
         the file was flagged for further research and to be revisited later
         in time.
      
      In total, over 70 hours of logged manual review was done on the
      spreadsheet to determine the SPDX license identifiers to apply to the
      source files by Kate, Philippe, Thomas and, in some cases, confirmation
      by lawyers working with the Linux Foundation.
      
      Kate also obtained a third independent scan of the 4.13 code base from
      FOSSology, and compared selected files where the other two scanners
      disagreed against that SPDX file, to see if there was new insights.  The
      Windriver scanner is based on an older version of FOSSology in part, so
      they are related.
      
      Thomas did random spot checks in about 500 files from the spreadsheets
      for the uapi headers and agreed with SPDX license identifier in the
      files he inspected. For the non-uapi files Thomas did random spot checks
      in about 15000 files.
      
      In initial set of patches against 4.14-rc6, 3 files were found to have
      copy/paste license identifier errors, and have been fixed to reflect the
      correct identifier.
      
      Additionally Philippe spent 10 hours this week doing a detailed manual
      inspection and review of the 12,461 patched files from the initial patch
      version early this week with:
       - a full scancode scan run, collecting the matched texts, detected
         license ids and scores
       - reviewing anything where there was a license detected (about 500+
         files) to ensure that the applied SPDX license was correct
       - reviewing anything where there was no detection but the patch license
         was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
         SPDX license was correct
      
      This produced a worksheet with 20 files needing minor correction.  This
      worksheet was then exported into 3 different .csv files for the
      different types of files to be modified.
      
      These .csv files were then reviewed by Greg.  Thomas wrote a script to
      parse the csv files and add the proper SPDX tag to the file, in the
      format that the file expected.  This script was further refined by Greg
      based on the output to detect more types of files automatically and to
      distinguish between header and source .c files (which need different
      comment types.)  Finally Greg ran the script using the .csv files to
      generate the patches.
      Reviewed-by: default avatarKate Stewart <kstewart@linuxfoundation.org>
      Reviewed-by: default avatarPhilippe Ombredanne <pombredanne@nexb.com>
      Reviewed-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      b2441318
    • Bhumika Goyal's avatar
      clk: hisilicon: make clk_ops const · 9108620d
      Bhumika Goyal authored
      Make these const as they are only stored in the const field of a
      clk_init_data structure.
      Signed-off-by: default avatarBhumika Goyal <bhumirks@gmail.com>
      Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
      9108620d
  15. 01 Nov, 2017 1 commit
    • Leo Yan's avatar
      clk: hi6220: mark clock cs_atb_syspll as critical · d2a3671e
      Leo Yan authored
      Clock cs_atb_syspll is pll used for coresight trace bus; when clock
      cs_atb_syspll is disabled and operates its child clock node cs_atb
      results in system hang. So mark clock cs_atb_syspll as critical to
      keep it enabled.
      
      Cc: Guodong Xu <guodong.xu@linaro.org>
      Cc: Zhangfei Gao <zhangfei.gao@linaro.org>
      Cc: Haojian Zhuang <haojian.zhuang@linaro.org>
      Signed-off-by: default avatarLeo Yan <leo.yan@linaro.org>
      Signed-off-by: default avatarMichael Turquette <mturquette@baylibre.com>
      Link: lkml.kernel.org/r/1504226835-2115-2-git-send-email-leo.yan@linaro.org
      d2a3671e
  16. 01 Sep, 2017 1 commit
  17. 21 Jun, 2017 1 commit
  18. 20 Jun, 2017 4 commits
  19. 19 Jun, 2017 1 commit
    • Leo Yan's avatar
      clk: Hi3660: register fixed_rate_clks with CLK_OF_DECLARE_DRIVER · a925810f
      Leo Yan authored
      The timer will register into system at very early phase at kernel boot;
      if timer needs to use clock, the clock should be get ready in function
      of_clk_init() so later the timer driver probe can retrieve clock
      successfully. This is finished in below flow on arm64:
      
        start_kernel()
          `-> time_init()
                `-> of_clk_init(NULL)    => register timer's clock
                `-> clocksource_probe()  => register timer
      
      On Hi3660 the sp804 timer uses clock "osc32k", this clock is registered
      as platform driver rather than CLK_OF_DECLARE_DRIVER method. As result,
      sp804 timer probe returns failure due if cannot bind clock properly.
      
      To fix the failure, this patch is to split crgctrl clocks into two
      subsets. One part is for fixed_rate_clks which includes pre-defined
      fixed rate clocks, and "osc32k" clock is in this category; So we change
      their registration to CLK_OF_DECLARE_DRIVER method, as result the clocks
      can be registered ahead with function of_clk_init() and timer driver can
      bind timer clock successfully; the rest of the crgctrl clocks are still
      registered by the probe of the platform driver.
      
      This patch also adds checking for all crgctrl clocks registration and
      print out log if any clock has failure.
      Signed-off-by: default avatarLeo Yan <leo.yan@linaro.org>
      Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
      a925810f
  20. 19 Apr, 2017 6 commits
  21. 12 Apr, 2017 1 commit
  22. 27 Jan, 2017 1 commit
    • Leo Yan's avatar
      clk: hisilicon: fix lock assignment · 55da97e3
      Leo Yan authored
      In clock driver initialize phase the spinlock is missed to assignment
      to struct clkgate_separated, finally there have no locking to protect
      exclusive accessing for clock registers.
      
      This bug introduces the console has no output after enable coresight
      driver on 96boards Hikey; this is because console using UART3, which
      has shared the same register with coresight clock enabling bit. After
      applied this patch it can assign lock properly to protect exclusive
      accessing, and console can work well after enabled coresight modules.
      
      Fixes: 0aa0c95f ("clk: hisilicon: add common clock support")
      Signed-off-by: default avatarLeo Yan <leo.yan@linaro.org>
      Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
      55da97e3
  23. 10 Jan, 2017 1 commit