Commit bff7e067 authored by Wei Yongjun's avatar Wei Yongjun Committed by Mike Snitzer

dm flakey: return -EINVAL on interval bounds error in flakey_ctr()

Fix to return error code -EINVAL instead of 0, as is done elsewhere in
this function.

Fixes: e80d1c80 ("dm: do not override error code returned from dm_get_device()")
Cc: # 4.3+
Signed-off-by: default avatarWei Yongjun <>
Signed-off-by: default avatarMike Snitzer <>
parent 1b1b58f5
......@@ -200,11 +200,13 @@ static int flakey_ctr(struct dm_target *ti, unsigned int argc, char **argv)
if (!(fc->up_interval + fc->down_interval)) {
ti->error = "Total (up + down) interval is zero";
r = -EINVAL;
goto bad;
if (fc->up_interval + fc->down_interval < fc->up_interval) {
ti->error = "Interval overflow";
r = -EINVAL;
goto bad;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment