Commit a1edf87f authored by LABBE Corentin's avatar LABBE Corentin Committed by Linus Walleij

pinctrl: palmas: fix a possible NULL dereference

of_match_device could return NULL, and so cause a NULL pointer
dereference later at line 1009:
pinctrl_data = match->data;

For fixing this problem, we use of_device_get_match_data(), this will
simplify the code a little by using a standard function for
getting the match data.

Reported-by: coverity (CID 1324136)
Signed-off-by: default avatarLABBE Corentin <>
Signed-off-by: Linus Walleij's avatarLinus Walleij <>
parent 26fecf0b
...@@ -1004,9 +1004,7 @@ static int palmas_pinctrl_probe(struct platform_device *pdev) ...@@ -1004,9 +1004,7 @@ static int palmas_pinctrl_probe(struct platform_device *pdev)
bool enable_dvfs2 = false; bool enable_dvfs2 = false;
if (pdev->dev.of_node) { if (pdev->dev.of_node) {
const struct of_device_id *match; pinctrl_data = of_device_get_match_data(&pdev->dev);
match = of_match_device(palmas_pinctrl_of_match, &pdev->dev);
pinctrl_data = match->data;
enable_dvfs1 = of_property_read_bool(pdev->dev.of_node, enable_dvfs1 = of_property_read_bool(pdev->dev.of_node,
"ti,palmas-enable-dvfs1"); "ti,palmas-enable-dvfs1");
enable_dvfs2 = of_property_read_bool(pdev->dev.of_node, enable_dvfs2 = of_property_read_bool(pdev->dev.of_node,
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment