Commit 74cf5b16 authored by Wei Wang's avatar Wei Wang Committed by Michael S. Tsirkin

virtio-balloon: remove BUG() in init_vqs

It's a bit overkill to use BUG when failing to add an entry to the
stats_vq in init_vqs. So remove it and just return the error to the
caller to bail out nicely.
Signed-off-by: default avatarWei Wang <>
Cc: Michael S. Tsirkin <>
Signed-off-by: default avatarMichael S. Tsirkin <>
parent 94710cac
......@@ -455,9 +455,13 @@ static int init_vqs(struct virtio_balloon *vb)
num_stats = update_balloon_stats(vb);
sg_init_one(&sg, vb->stats, sizeof(vb->stats[0]) * num_stats);
if (virtqueue_add_outbuf(vb->stats_vq, &sg, 1, vb, GFP_KERNEL)
< 0)
err = virtqueue_add_outbuf(vb->stats_vq, &sg, 1, vb,
if (err) {
dev_warn(&vb->vdev->dev, "%s: add stat_vq failed\n",
return err;
return 0;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment