Commit 4d5a91fd authored by Wei Yongjun's avatar Wei Yongjun Committed by Bjorn Andersson

hwspinlock: fix return value check in stm32_hwspinlock_probe()

In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Fixes: f24fcff1 ("hwspinlock: add STM32 hwspinlock device")
Acked-by: default avatarBenjamin Gaignard <>
Signed-off-by: default avatarWei Yongjun <>
Signed-off-by: default avatarBjorn Andersson <>
parent f24fcff1
......@@ -57,8 +57,8 @@ static int stm32_hwspinlock_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
io_base = devm_ioremap_resource(&pdev->dev, res);
if (!io_base)
return -ENOMEM;
if (IS_ERR(io_base))
return PTR_ERR(io_base);
array_size = STM32_MUTEX_NUM_LOCKS * sizeof(struct hwspinlock);
hw = devm_kzalloc(&pdev->dev, sizeof(*hw) + array_size, GFP_KERNEL);
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment