Commit 4bb0e6d7 authored by Julia Lawall's avatar Julia Lawall Committed by Maxime Ripard

drm/sun4i: backend: add missing of_node_puts

The device node iterators perform an of_node_get on each
iteration, so a jump out of the loop requires an of_node_put.

Remote and port also have augmented reference counts, so drop them
on each iteration and at the end of the function, respectively.
Remote is only used for the address it contains, not for the
contents of that address, so the reference count can be dropped

The semantic patch that fixes the first part of this problem is
as follows (

// <smpl>
expression root,e;
local idexpression child;
iterator name for_each_child_of_node;

 for_each_available_child_of_node(root, child) {
   ... when != of_node_put(child)
       when != e = child
+  of_node_put(child);
?  break;
... when != child
// </smpl>
Signed-off-by: default avatarJulia Lawall <>
Signed-off-by: default avatarMaxime Ripard <>
parent ce0210c1
......@@ -786,17 +786,18 @@ static struct sun4i_frontend *sun4i_backend_find_frontend(struct sun4i_drv *drv,
remote = of_graph_get_remote_port_parent(ep);
if (!remote)
/* does this node match any registered engines? */
list_for_each_entry(frontend, &drv->frontend_list, list) {
if (remote == frontend->node) {
return frontend;
return ERR_PTR(-EINVAL);
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment