Skip to content
  • Martin Blumenstingl's avatar
    clk: meson: clk-pll: check if the clock is already enabled · d6e81845
    Martin Blumenstingl authored and Neil Armstrong's avatar Neil Armstrong committed
    
    
    Since commit 6f888e7bc7bd58 ("clk: meson: clk-pll: add enable bit") our
    PLLs also support the "enable" bit. Currently meson_clk_pll_enable
    unconditionally resets the PLL, enables it, takes it out of reset and
    waits until it is locked.
    
    This works fine for our current clock trees. However, there will be a
    problem once we allow modifications to sys_pll on Meson8, Meson8b and
    Meson8m2 (which will be required for CPU frequency scaling):
    the CPU clock is derived from the sys_pll clock. Once clk_enable is
    called on the CPU clock this will be propagated by the common clock
    framework up until the sys_pll clock. If we reset the PLL
    unconditionally in meson_clk_pll_enable the CPU will be stopped (on
    Meson8, Meson8b and Meson8m2).
    To prevent this we simply check if the PLL is already enabled and do
    reset the PLL if it's already enabled and locked.
    
    Now that we have a utility function to check whether the PLL is enabled
    we can also pass that to our clk_ops to let the common clock framework
    know about the status of the hardware clock.
    For now this is of limited use since the only common clock framework's
    internal "disabled unused clocks" mechanism checks for this. Everything
    else still uses the ref-counting (internal to the common clock
    framework) when clk_enable is called.
    
    Signed-off-by: default avatarMartin Blumenstingl <martin.blumenstingl@googlemail.com>
    Reviewed-by: default avatarJerome Brunet <jbrunet@baylibre.com>
    Signed-off-by: default avatarNeil Armstrong <narmstrong@baylibre.com>
    Link: https://lkml.kernel.org/r/20181115224048.13511-2-martin.blumenstingl@googlemail.com
    d6e81845