• Nathan Chancellor's avatar
    cpufreq: qcom-kryo: Fix section annotations · d51aea13
    Nathan Chancellor authored
    There is currently a warning when building the Kryo cpufreq driver into
    the kernel image:
    WARNING: vmlinux.o(.text+0x8aa424): Section mismatch in reference from
    the function qcom_cpufreq_kryo_probe() to the function
    The function qcom_cpufreq_kryo_probe() references
    the function __init qcom_cpufreq_kryo_get_msm_id().
    This is often because qcom_cpufreq_kryo_probe lacks a __init
    annotation or the annotation of qcom_cpufreq_kryo_get_msm_id is wrong.
    Remove the '__init' annotation from qcom_cpufreq_kryo_get_msm_id
    so that there is no more mismatch warning.
    Additionally, Nick noticed that the remove function was marked as
    '__init' when it should really be marked as '__exit'.
    Fixes: 46e2856b (cpufreq: Add Kryo CPU scaling driver)
    Fixes: 5ad7346b (cpufreq: kryo: Add module remove and exit)
    Reported-by: default avatarNick Desaulniers <ndesaulniers@google.com>
    Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
    Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
    Cc: 4.18+ <stable@vger.kernel.org> # 4.18+
    Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
qcom-cpufreq-kryo.c 5.53 KB