Skip to content
  • Thierry Reding's avatar
    scripts/spdxcheck.py: always open files in binary mode · 3a6ab5c7
    Thierry Reding authored
    The spdxcheck script currently falls over when confronted with a binary
    file (such as Documentation/logo.gif).  To avoid that, always open files
    in binary mode and decode line-by-line, ignoring encoding errors.
    
    One tricky case is when piping data into the script and reading it from
    standard input.  By default, standard input will be opened in text mode,
    so we need to reopen it in binary mode.
    
    The breakage only happens with python3 and results in a
    UnicodeDecodeError (according to Uwe).
    
    Link: http://lkml.kernel.org/r/20181212131210.28024-1-thierry.reding@gmail.com
    Fixes: 6f4d29df
    
     ("scripts/spdxcheck.py: make python3 compliant")
    Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
    Reviewed-by: default avatarJeremy Cline <jcline@redhat.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Jonathan Corbet <corbet@lwn.net>
    Cc: Joe Perches <joe@perches.com>
    Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Andrew Morton <...
    3a6ab5c7