• Rob Herring's avatar
    fbdev: offb: Fix OF node name handling · 00257e0c
    Rob Herring authored
    Commit 5c63e407 ("fbdev: Convert to using %pOFn instead of
    device_node.name") changed how the OF FB driver handles the OF node
    name. This missed the case where the node name is passed to
    offb_init_palette_hacks(). This results in a NULL ptr dereference
    in strncmp and breaks any system except ones using bootx with no display
    node.
    
    Fix this by making offb_init_palette_hacks() use the OF node pointer and
    use of_node_name_prefix() helper function instead for node name
    comparisons. This helps in moving all OF node name accesses to helper
    functions in preparation to remove struct device_node.name pointer.
    
    Fixes: 5c63e407 ("fbdev: Convert to using %pOFn instead of device_node.name")
    Reported-by: default avatarMathieu Malaterre <malat@debian.org>
    Tested-by: default avatarMathieu Malaterre <malat@debian.org>
    Cc: stable@vger.kernel.org # v4.19+
    Cc: Elimar Riesebieter <riesebie@lxtec.de>
    Signed-off-by: Rob Herring's avatarRob Herring <robh@kernel.org>
    Signed-off-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
    00257e0c
offb.c 19.9 KB