Skip to content
  • Arnd Bergmann's avatar
    Input: adxl34x - do not treat FIFO_MODE() as boolean · 1dbc080c
    Arnd Bergmann authored
    FIFO_MODE() is a macro expression with a '<<' operator, which gcc points
    out could be misread as a '<':
    
    drivers/input/misc/adxl34x.c: In function 'adxl34x_probe':
    drivers/input/misc/adxl34x.c:799:36: error: '<<' in boolean context, did you mean '<' ? [-Werror=int-in-bool-context]
    
    While utility of this warning is being disputed (Chief Penguin: "This
    warning is clearly pure garbage.") FIFO_MODE() extracts range of values,
    with 0 being FIFO_BYPASS, and not something that is logically boolean.
    
    This converts the test to an explicit comparison with FIFO_BYPASS,
    making it clearer to gcc and the reader what is intended.
    
    Fixes: e27c7292
    
     ("Input: add driver for ADXL345/346 Digital Accelerometers")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
    1dbc080c