• Dmitry Torokhov's avatar
    Input: do not use WARN() in input_alloc_absinfo() · 100294ce
    Dmitry Torokhov authored
    Some of fuzzers set panic_on_warn=1 so that they can handle WARN()ings
    the same way they handle full-blown kernel crashes. We used WARN() in
    input_alloc_absinfo() to get a better idea where memory allocation
    failed, but since then kmalloc() and friends started dumping call stack on
    memory allocation failures anyway, so we are not getting anything extra
    from WARN().
    Because of the above, let's replace WARN with dev_err(). We use dev_err()
    instead of simply removing message and relying on kcalloc() to give us
    stack dump so that we'd know the instance of hardware device to which we
    were trying to attach input device.
    Reported-by: default avatarDmitry Vyukov <dvyukov@google.com>
    Acked-by: default avatarDmitry Vyukov <dvyukov@google.com>
    Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
input.c 60.7 KB