edac_device_sysfs.c 23.2 KB
Newer Older
1
/*
2
 * file for managing the edac_device subsystem of devices for EDAC
3
 *
4
 * (C) 2007 SoftwareBitMaker
5
 *
6 7 8 9 10 11 12 13
 * This file may be distributed under the terms of the
 * GNU General Public License.
 *
 * Written Doug Thompson <norsk5@xmission.com>
 *
 */

#include <linux/ctype.h>
14
#include <linux/module.h>
15
#include <linux/slab.h>
16
#include <linux/edac.h>
17

18
#include "edac_device.h"
19 20 21 22 23 24 25 26 27 28 29 30 31
#include "edac_module.h"

#define EDAC_DEVICE_SYMLINK	"device"

#define to_edacdev(k) container_of(k, struct edac_device_ctl_info, kobj)
#define to_edacdev_attr(a) container_of(a, struct edacdev_attribute, attr)


/*
 * Set of edac_device_ctl_info attribute store/show functions
 */

/* 'log_ue' */
32
static ssize_t edac_device_ctl_log_ue_show(struct edac_device_ctl_info
33
					*ctl_info, char *data)
34
{
35
	return sprintf(data, "%u\n", ctl_info->log_ue);
36 37
}

38
static ssize_t edac_device_ctl_log_ue_store(struct edac_device_ctl_info
39 40
					*ctl_info, const char *data,
					size_t count)
41 42
{
	/* if parameter is zero, turn off flag, if non-zero turn on flag */
43
	ctl_info->log_ue = (simple_strtoul(data, NULL, 0) != 0);
44

45
	return count;
46 47 48
}

/* 'log_ce' */
49
static ssize_t edac_device_ctl_log_ce_show(struct edac_device_ctl_info
50
					*ctl_info, char *data)
51
{
52
	return sprintf(data, "%u\n", ctl_info->log_ce);
53 54
}

55
static ssize_t edac_device_ctl_log_ce_store(struct edac_device_ctl_info
56 57
					*ctl_info, const char *data,
					size_t count)
58 59
{
	/* if parameter is zero, turn off flag, if non-zero turn on flag */
60
	ctl_info->log_ce = (simple_strtoul(data, NULL, 0) != 0);
61

62
	return count;
63 64 65
}

/* 'panic_on_ue' */
66 67
static ssize_t edac_device_ctl_panic_on_ue_show(struct edac_device_ctl_info
						*ctl_info, char *data)
68
{
69
	return sprintf(data, "%u\n", ctl_info->panic_on_ue);
70 71
}

72 73 74
static ssize_t edac_device_ctl_panic_on_ue_store(struct edac_device_ctl_info
						 *ctl_info, const char *data,
						 size_t count)
75 76
{
	/* if parameter is zero, turn off flag, if non-zero turn on flag */
77
	ctl_info->panic_on_ue = (simple_strtoul(data, NULL, 0) != 0);
78 79 80 81 82

	return count;
}

/* 'poll_msec' show and store functions*/
83
static ssize_t edac_device_ctl_poll_msec_show(struct edac_device_ctl_info
84
					*ctl_info, char *data)
85
{
86
	return sprintf(data, "%u\n", ctl_info->poll_msec);
87 88
}

89
static ssize_t edac_device_ctl_poll_msec_store(struct edac_device_ctl_info
90 91
					*ctl_info, const char *data,
					size_t count)
92 93 94 95 96 97 98 99
{
	unsigned long value;

	/* get the value and enforce that it is non-zero, must be at least
	 * one millisecond for the delay period, between scans
	 * Then cancel last outstanding delay for the work request
	 * and set a new one.
	 */
100 101
	value = simple_strtoul(data, NULL, 0);
	edac_device_reset_delay_period(ctl_info, value);
102

103
	return count;
104 105 106 107
}

/* edac_device_ctl_info specific attribute structure */
struct ctl_info_attribute {
108
	struct attribute attr;
109 110
	ssize_t(*show) (struct edac_device_ctl_info *, char *);
	ssize_t(*store) (struct edac_device_ctl_info *, const char *, size_t);
111 112 113 114 115 116 117
};

#define to_ctl_info(k) container_of(k, struct edac_device_ctl_info, kobj)
#define to_ctl_info_attr(a) container_of(a,struct ctl_info_attribute,attr)

/* Function to 'show' fields from the edac_dev 'ctl_info' structure */
static ssize_t edac_dev_ctl_info_show(struct kobject *kobj,
118
				struct attribute *attr, char *buffer)
119
{
120 121
	struct edac_device_ctl_info *edac_dev = to_ctl_info(kobj);
	struct ctl_info_attribute *ctl_info_attr = to_ctl_info_attr(attr);
122

123 124 125
	if (ctl_info_attr->show)
		return ctl_info_attr->show(edac_dev, buffer);
	return -EIO;
126 127 128 129
}

/* Function to 'store' fields into the edac_dev 'ctl_info' structure */
static ssize_t edac_dev_ctl_info_store(struct kobject *kobj,
130 131
				struct attribute *attr,
				const char *buffer, size_t count)
132
{
133 134
	struct edac_device_ctl_info *edac_dev = to_ctl_info(kobj);
	struct ctl_info_attribute *ctl_info_attr = to_ctl_info_attr(attr);
135

136 137 138
	if (ctl_info_attr->store)
		return ctl_info_attr->store(edac_dev, buffer, count);
	return -EIO;
139 140 141
}

/* edac_dev file operations for an 'ctl_info' */
142
static const struct sysfs_ops device_ctl_info_ops = {
143 144
	.show = edac_dev_ctl_info_show,
	.store = edac_dev_ctl_info_store
145 146 147 148
};

#define CTL_INFO_ATTR(_name,_mode,_show,_store)        \
static struct ctl_info_attribute attr_ctl_info_##_name = {      \
149 150 151
	.attr = {.name = __stringify(_name), .mode = _mode },   \
	.show   = _show,                                        \
	.store  = _store,                                       \
152 153 154
};

/* Declare the various ctl_info attributes here and their respective ops */
155
CTL_INFO_ATTR(log_ue, S_IRUGO | S_IWUSR,
156
	edac_device_ctl_log_ue_show, edac_device_ctl_log_ue_store);
157
CTL_INFO_ATTR(log_ce, S_IRUGO | S_IWUSR,
158
	edac_device_ctl_log_ce_show, edac_device_ctl_log_ce_store);
159
CTL_INFO_ATTR(panic_on_ue, S_IRUGO | S_IWUSR,
160 161
	edac_device_ctl_panic_on_ue_show,
	edac_device_ctl_panic_on_ue_store);
162
CTL_INFO_ATTR(poll_msec, S_IRUGO | S_IWUSR,
163
	edac_device_ctl_poll_msec_show, edac_device_ctl_poll_msec_store);
164 165 166 167 168 169 170 171 172 173

/* Base Attributes of the EDAC_DEVICE ECC object */
static struct ctl_info_attribute *device_ctrl_attr[] = {
	&attr_ctl_info_panic_on_ue,
	&attr_ctl_info_log_ue,
	&attr_ctl_info_log_ce,
	&attr_ctl_info_poll_msec,
	NULL,
};

174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200
/*
 * edac_device_ctrl_master_release
 *
 *	called when the reference count for the 'main' kobj
 *	for a edac_device control struct reaches zero
 *
 *	Reference count model:
 *		One 'main' kobject for each control structure allocated.
 *		That main kobj is initially set to one AND
 *		the reference count for the EDAC 'core' module is
 *		bumped by one, thus added 'keep in memory' dependency.
 *
 *		Each new internal kobj (in instances and blocks) then
 *		bumps the 'main' kobject.
 *
 *		When they are released their release functions decrement
 *		the 'main' kobj.
 *
 *		When the main kobj reaches zero (0) then THIS function
 *		is called which then decrements the EDAC 'core' module.
 *		When the module reference count reaches zero then the
 *		module no longer has dependency on keeping the release
 *		function code in memory and module can be unloaded.
 *
 *		This will support several control objects as well, each
 *		with its own 'main' kobj.
 */
201 202
static void edac_device_ctrl_master_release(struct kobject *kobj)
{
203
	struct edac_device_ctl_info *edac_dev = to_edacdev(kobj);
204

205
	edac_dbg(4, "control index=%d\n", edac_dev->dev_idx);
206

207 208 209 210 211 212 213
	/* decrement the EDAC CORE module ref count */
	module_put(edac_dev->owner);

	/* free the control struct containing the 'main' kobj
	 * passed in to this routine
	 */
	kfree(edac_dev);
214 215
}

216
/* ktype for the main (master) kobject */
217 218 219
static struct kobj_type ktype_device_ctrl = {
	.release = edac_device_ctrl_master_release,
	.sysfs_ops = &device_ctl_info_ops,
220
	.default_attrs = (struct attribute **)device_ctrl_attr,
221 222 223
};

/*
224
 * edac_device_register_sysfs_main_kobj
225 226 227 228 229 230
 *
 *	perform the high level setup for the new edac_device instance
 *
 * Return:  0 SUCCESS
 *         !0 FAILURE
 */
231
int edac_device_register_sysfs_main_kobj(struct edac_device_ctl_info *edac_dev)
232
{
233
	struct bus_type *edac_subsys;
234
	int err;
235

236
	edac_dbg(1, "\n");
237

238
	/* get the /sys/devices/system/edac reference */
239
	edac_subsys = edac_get_sysfs_subsys();
240

241 242
	/* Point to the 'edac_subsys' this instance 'reports' to */
	edac_dev->edac_subsys = edac_subsys;
243 244

	/* Init the devices's kobject */
245
	memset(&edac_dev->kobj, 0, sizeof(struct kobject));
246 247 248 249 250 251 252 253

	/* Record which module 'owns' this control structure
	 * and bump the ref count of the module
	 */
	edac_dev->owner = THIS_MODULE;

	if (!try_module_get(edac_dev->owner)) {
		err = -ENODEV;
254
		goto err_out;
255 256 257
	}

	/* register */
258
	err = kobject_init_and_add(&edac_dev->kobj, &ktype_device_ctrl,
259
				   &edac_subsys->dev_root->kobj,
260
				   "%s", edac_dev->name);
261
	if (err) {
262 263
		edac_dbg(1, "Failed to register '.../edac/%s'\n",
			 edac_dev->name);
264
		goto err_kobj_reg;
265
	}
266
	kobject_uevent(&edac_dev->kobj, KOBJ_ADD);
267

268 269 270 271
	/* At this point, to 'free' the control struct,
	 * edac_device_unregister_sysfs_main_kobj() must be used
	 */

272
	edac_dbg(4, "Registered '.../edac/%s' kobject\n", edac_dev->name);
273 274

	return 0;
275 276 277 278 279 280 281

	/* Error exit stack */
err_kobj_reg:
	module_put(edac_dev->owner);

err_out:
	return err;
282 283 284
}

/*
285
 * edac_device_unregister_sysfs_main_kobj:
286 287
 *	the '..../edac/<name>' kobject
 */
288
void edac_device_unregister_sysfs_main_kobj(struct edac_device_ctl_info *dev)
289
{
290 291
	edac_dbg(0, "\n");
	edac_dbg(4, "name of kobject is: %s\n", kobject_name(&dev->kobj));
292 293 294

	/*
	 * Unregister the edac device's kobject and
295 296 297 298
	 * allow for reference count to reach 0 at which point
	 * the callback will be called to:
	 *   a) module_put() this module
	 *   b) 'kfree' the memory
299
	 */
300
	kobject_put(&dev->kobj);
301 302
}

303
/* edac_dev -> instance information */
304 305 306 307

/*
 * Set of low-level instance attribute show functions
 */
308
static ssize_t instance_ue_count_show(struct edac_device_instance *instance,
309
				char *data)
310
{
311
	return sprintf(data, "%u\n", instance->counters.ue_count);
312 313
}

314
static ssize_t instance_ce_count_show(struct edac_device_instance *instance,
315
				char *data)
316
{
317
	return sprintf(data, "%u\n", instance->counters.ce_count);
318 319 320 321 322 323 324 325 326 327
}

#define to_instance(k) container_of(k, struct edac_device_instance, kobj)
#define to_instance_attr(a) container_of(a,struct instance_attribute,attr)

/* DEVICE instance kobject release() function */
static void edac_device_ctrl_instance_release(struct kobject *kobj)
{
	struct edac_device_instance *instance;

328
	edac_dbg(1, "\n");
329

330 331 332
	/* map from this kobj to the main control struct
	 * and then dec the main kobj count
	 */
333
	instance = to_instance(kobj);
334
	kobject_put(&instance->ctl->kobj);
335 336 337 338
}

/* instance specific attribute structure */
struct instance_attribute {
339
	struct attribute attr;
340 341
	ssize_t(*show) (struct edac_device_instance *, char *);
	ssize_t(*store) (struct edac_device_instance *, const char *, size_t);
342 343 344 345
};

/* Function to 'show' fields from the edac_dev 'instance' structure */
static ssize_t edac_dev_instance_show(struct kobject *kobj,
346
				struct attribute *attr, char *buffer)
347
{
348 349
	struct edac_device_instance *instance = to_instance(kobj);
	struct instance_attribute *instance_attr = to_instance_attr(attr);
350

351 352 353
	if (instance_attr->show)
		return instance_attr->show(instance, buffer);
	return -EIO;
354 355 356 357
}

/* Function to 'store' fields into the edac_dev 'instance' structure */
static ssize_t edac_dev_instance_store(struct kobject *kobj,
358 359
				struct attribute *attr,
				const char *buffer, size_t count)
360
{
361 362
	struct edac_device_instance *instance = to_instance(kobj);
	struct instance_attribute *instance_attr = to_instance_attr(attr);
363

364 365 366
	if (instance_attr->store)
		return instance_attr->store(instance, buffer, count);
	return -EIO;
367 368 369
}

/* edac_dev file operations for an 'instance' */
370
static const struct sysfs_ops device_instance_ops = {
371 372
	.show = edac_dev_instance_show,
	.store = edac_dev_instance_store
373 374 375 376
};

#define INSTANCE_ATTR(_name,_mode,_show,_store)        \
static struct instance_attribute attr_instance_##_name = {      \
377 378 379
	.attr = {.name = __stringify(_name), .mode = _mode },   \
	.show   = _show,                                        \
	.store  = _store,                                       \
380 381 382 383 384 385 386
};

/*
 * Define attributes visible for the edac_device instance object
 *	Each contains a pointer to a show and an optional set
 *	function pointer that does the low level output/input
 */
387 388
INSTANCE_ATTR(ce_count, S_IRUGO, instance_ce_count_show, NULL);
INSTANCE_ATTR(ue_count, S_IRUGO, instance_ue_count_show, NULL);
389 390 391 392 393 394 395 396 397 398 399 400

/* list of edac_dev 'instance' attributes */
static struct instance_attribute *device_instance_attr[] = {
	&attr_instance_ce_count,
	&attr_instance_ue_count,
	NULL,
};

/* The 'ktype' for each edac_dev 'instance' */
static struct kobj_type ktype_instance_ctrl = {
	.release = edac_device_ctrl_instance_release,
	.sysfs_ops = &device_instance_ops,
401
	.default_attrs = (struct attribute **)device_instance_attr,
402 403
};

404
/* edac_dev -> instance -> block information */
405

406 407 408 409
#define to_block(k) container_of(k, struct edac_device_block, kobj)
#define to_block_attr(a) \
	container_of(a, struct edac_dev_sysfs_block_attribute, attr)

410 411 412
/*
 * Set of low-level block attribute show functions
 */
413 414
static ssize_t block_ue_count_show(struct kobject *kobj,
					struct attribute *attr, char *data)
415
{
416 417
	struct edac_device_block *block = to_block(kobj);

418
	return sprintf(data, "%u\n", block->counters.ue_count);
419 420
}

421 422
static ssize_t block_ce_count_show(struct kobject *kobj,
					struct attribute *attr, char *data)
423
{
424 425
	struct edac_device_block *block = to_block(kobj);

426
	return sprintf(data, "%u\n", block->counters.ce_count);
427 428 429 430 431 432 433
}

/* DEVICE block kobject release() function */
static void edac_device_ctrl_block_release(struct kobject *kobj)
{
	struct edac_device_block *block;

434
	edac_dbg(1, "\n");
435

436
	/* get the container of the kobj */
437
	block = to_block(kobj);
438 439 440 441 442

	/* map from 'block kobj' to 'block->instance->controller->main_kobj'
	 * now 'release' the block kobject
	 */
	kobject_put(&block->instance->ctl->kobj);
443 444 445 446 447
}


/* Function to 'show' fields from the edac_dev 'block' structure */
static ssize_t edac_dev_block_show(struct kobject *kobj,
448
				struct attribute *attr, char *buffer)
449
{
450 451
	struct edac_dev_sysfs_block_attribute *block_attr =
						to_block_attr(attr);
452

453
	if (block_attr->show)
454
		return block_attr->show(kobj, attr, buffer);
455
	return -EIO;
456 457 458 459
}

/* Function to 'store' fields into the edac_dev 'block' structure */
static ssize_t edac_dev_block_store(struct kobject *kobj,
460 461
				struct attribute *attr,
				const char *buffer, size_t count)
462
{
463 464 465
	struct edac_dev_sysfs_block_attribute *block_attr;

	block_attr = to_block_attr(attr);
466

467
	if (block_attr->store)
468
		return block_attr->store(kobj, attr, buffer, count);
469
	return -EIO;
470 471 472
}

/* edac_dev file operations for a 'block' */
473
static const struct sysfs_ops device_block_ops = {
474 475
	.show = edac_dev_block_show,
	.store = edac_dev_block_store
476 477 478
};

#define BLOCK_ATTR(_name,_mode,_show,_store)        \
479
static struct edac_dev_sysfs_block_attribute attr_block_##_name = {	\
480 481 482
	.attr = {.name = __stringify(_name), .mode = _mode },   \
	.show   = _show,                                        \
	.store  = _store,                                       \
483 484
};

485 486
BLOCK_ATTR(ce_count, S_IRUGO, block_ce_count_show, NULL);
BLOCK_ATTR(ue_count, S_IRUGO, block_ue_count_show, NULL);
487 488

/* list of edac_dev 'block' attributes */
489
static struct edac_dev_sysfs_block_attribute *device_block_attr[] = {
490 491 492 493 494 495 496 497 498
	&attr_block_ce_count,
	&attr_block_ue_count,
	NULL,
};

/* The 'ktype' for each edac_dev 'block' */
static struct kobj_type ktype_block_ctrl = {
	.release = edac_device_ctrl_block_release,
	.sysfs_ops = &device_block_ops,
499
	.default_attrs = (struct attribute **)device_block_attr,
500 501
};

502
/* block ctor/dtor  code */
503 504 505 506

/*
 * edac_device_create_block
 */
507
static int edac_device_create_block(struct edac_device_ctl_info *edac_dev,
508
				struct edac_device_instance *instance,
509
				struct edac_device_block *block)
510
{
511
	int i;
512
	int err;
513
	struct edac_dev_sysfs_block_attribute *sysfs_attrib;
514
	struct kobject *main_kobj;
515

516 517 518 519
	edac_dbg(4, "Instance '%s' inst_p=%p  block '%s'  block_p=%p\n",
		 instance->name, instance, block->name, block);
	edac_dbg(4, "block kobj=%p  block kobj->parent=%p\n",
		 &block->kobj, &block->kobj.parent);
520 521

	/* init this block's kobject */
522
	memset(&block->kobj, 0, sizeof(struct kobject));
523

524
	/* bump the main kobject's reference count for this controller
525
	 * and this instance is dependent on the main
526 527 528 529 530 531 532 533
	 */
	main_kobj = kobject_get(&edac_dev->kobj);
	if (!main_kobj) {
		err = -ENODEV;
		goto err_out;
	}

	/* Add this block's kobject */
534 535 536
	err = kobject_init_and_add(&block->kobj, &ktype_block_ctrl,
				   &instance->kobj,
				   "%s", block->name);
537
	if (err) {
538
		edac_dbg(1, "Failed to register instance '%s'\n", block->name);
539 540 541
		kobject_put(main_kobj);
		err = -ENODEV;
		goto err_out;
542 543
	}

544 545 546 547
	/* If there are driver level block attributes, then added them
	 * to the block kobject
	 */
	sysfs_attrib = block->block_attributes;
548 549 550
	if (sysfs_attrib && block->nr_attribs) {
		for (i = 0; i < block->nr_attribs; i++, sysfs_attrib++) {

551 552 553
			edac_dbg(4, "creating block attrib='%s' attrib->%p to kobj=%p\n",
				 sysfs_attrib->attr.name,
				 sysfs_attrib, &block->kobj);
554 555

			/* Create each block_attribute file */
556
			err = sysfs_create_file(&block->kobj,
557
				&sysfs_attrib->attr);
558 559 560 561
			if (err)
				goto err_on_attrib;
		}
	}
562
	kobject_uevent(&block->kobj, KOBJ_ADD);
563

564
	return 0;
565

566
	/* Error unwind stack */
567
err_on_attrib:
568
	kobject_put(&block->kobj);
569

570
err_out:
571
	return err;
572 573 574
}

/*
575
 * edac_device_delete_block(edac_dev,block);
576
 */
577
static void edac_device_delete_block(struct edac_device_ctl_info *edac_dev,
578
				struct edac_device_block *block)
579
{
580 581
	struct edac_dev_sysfs_block_attribute *sysfs_attrib;
	int i;
582

583 584 585 586 587
	/* if this block has 'attributes' then we need to iterate over the list
	 * and 'remove' the attributes on this block
	 */
	sysfs_attrib = block->block_attributes;
	if (sysfs_attrib && block->nr_attribs) {
588 589 590
		for (i = 0; i < block->nr_attribs; i++, sysfs_attrib++) {

			/* remove each block_attrib file */
591 592 593 594
			sysfs_remove_file(&block->kobj,
				(struct attribute *) sysfs_attrib);
		}
	}
595

596 597 598
	/* unregister this block's kobject, SEE:
	 *	edac_device_ctrl_block_release() callback operation
	 */
599
	kobject_put(&block->kobj);
600 601
}

602
/* instance ctor/dtor code */
603 604 605 606 607

/*
 * edac_device_create_instance
 *	create just one instance of an edac_device 'instance'
 */
608
static int edac_device_create_instance(struct edac_device_ctl_info *edac_dev,
609
				int idx)
610 611 612 613
{
	int i, j;
	int err;
	struct edac_device_instance *instance;
614
	struct kobject *main_kobj;
615 616 617 618

	instance = &edac_dev->instances[idx];

	/* Init the instance's kobject */
619
	memset(&instance->kobj, 0, sizeof(struct kobject));
620

621
	instance->ctl = edac_dev;
622

623
	/* bump the main kobject's reference count for this controller
624
	 * and this instance is dependent on the main
625 626 627 628 629 630
	 */
	main_kobj = kobject_get(&edac_dev->kobj);
	if (!main_kobj) {
		err = -ENODEV;
		goto err_out;
	}
631

632 633 634
	/* Formally register this instance's kobject under the edac_device */
	err = kobject_init_and_add(&instance->kobj, &ktype_instance_ctrl,
				   &edac_dev->kobj, "%s", instance->name);
635
	if (err != 0) {
636 637
		edac_dbg(2, "Failed to register instance '%s'\n",
			 instance->name);
638 639
		kobject_put(main_kobj);
		goto err_out;
640 641
	}

642 643
	edac_dbg(4, "now register '%d' blocks for instance %d\n",
		 instance->nr_blocks, idx);
644 645

	/* register all blocks of this instance */
646
	for (i = 0; i < instance->nr_blocks; i++) {
647 648
		err = edac_device_create_block(edac_dev, instance,
						&instance->blocks[i]);
649
		if (err) {
650
			/* If any fail, remove all previous ones */
651
			for (j = 0; j < i; j++)
652 653 654
				edac_device_delete_block(edac_dev,
							&instance->blocks[j]);
			goto err_release_instance_kobj;
655 656
		}
	}
657
	kobject_uevent(&instance->kobj, KOBJ_ADD);
658

659 660
	edac_dbg(4, "Registered instance %d '%s' kobject\n",
		 idx, instance->name);
661 662

	return 0;
663 664 665

	/* error unwind stack */
err_release_instance_kobj:
666
	kobject_put(&instance->kobj);
667 668 669

err_out:
	return err;
670 671 672 673 674 675
}

/*
 * edac_device_remove_instance
 *	remove an edac_device instance
 */
676 677
static void edac_device_delete_instance(struct edac_device_ctl_info *edac_dev,
					int idx)
678 679
{
	struct edac_device_instance *instance;
680
	int i;
681 682 683 684

	instance = &edac_dev->instances[idx];

	/* unregister all blocks in this instance */
685
	for (i = 0; i < instance->nr_blocks; i++)
686
		edac_device_delete_block(edac_dev, &instance->blocks[i]);
687

688 689 690
	/* unregister this instance's kobject, SEE:
	 *	edac_device_ctrl_instance_release() for callback operation
	 */
691
	kobject_put(&instance->kobj);
692 693 694 695 696 697 698 699 700 701 702 703
}

/*
 * edac_device_create_instances
 *	create the first level of 'instances' for this device
 *	(ie  'cache' might have 'cache0', 'cache1', 'cache2', etc
 */
static int edac_device_create_instances(struct edac_device_ctl_info *edac_dev)
{
	int i, j;
	int err;

704
	edac_dbg(0, "\n");
705 706

	/* iterate over creation of the instances */
707 708
	for (i = 0; i < edac_dev->nr_instances; i++) {
		err = edac_device_create_instance(edac_dev, i);
709 710
		if (err) {
			/* unwind previous instances on error */
711
			for (j = 0; j < i; j++)
712
				edac_device_delete_instance(edac_dev, j);
713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728
			return err;
		}
	}

	return 0;
}

/*
 * edac_device_delete_instances(edac_dev);
 *	unregister all the kobjects of the instances
 */
static void edac_device_delete_instances(struct edac_device_ctl_info *edac_dev)
{
	int i;

	/* iterate over creation of the instances */
729
	for (i = 0; i < edac_dev->nr_instances; i++)
730
		edac_device_delete_instance(edac_dev, i);
731 732
}

733
/* edac_dev sysfs ctor/dtor  code */
734

735
/*
736
 * edac_device_add_main_sysfs_attributes
737 738
 *	add some attributes to this instance's main kobject
 */
739
static int edac_device_add_main_sysfs_attributes(
740 741
			struct edac_device_ctl_info *edac_dev)
{
742
	struct edac_dev_sysfs_attribute *sysfs_attrib;
743
	int err = 0;
744 745

	sysfs_attrib = edac_dev->sysfs_attributes;
746 747 748 749 750 751
	if (sysfs_attrib) {
		/* iterate over the array and create an attribute for each
		 * entry in the list
		 */
		while (sysfs_attrib->attr.name != NULL) {
			err = sysfs_create_file(&edac_dev->kobj,
752
				(struct attribute*) sysfs_attrib);
753 754
			if (err)
				goto err_out;
755

756 757
			sysfs_attrib++;
		}
758
	}
759

760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784
err_out:
	return err;
}

/*
 * edac_device_remove_main_sysfs_attributes
 *	remove any attributes to this instance's main kobject
 */
static void edac_device_remove_main_sysfs_attributes(
			struct edac_device_ctl_info *edac_dev)
{
	struct edac_dev_sysfs_attribute *sysfs_attrib;

	/* if there are main attributes, defined, remove them. First,
	 * point to the start of the array and iterate over it
	 * removing each attribute listed from this device's instance's kobject
	 */
	sysfs_attrib = edac_dev->sysfs_attributes;
	if (sysfs_attrib) {
		while (sysfs_attrib->attr.name != NULL) {
			sysfs_remove_file(&edac_dev->kobj,
					(struct attribute *) sysfs_attrib);
			sysfs_attrib++;
		}
	}
785 786
}

787 788 789
/*
 * edac_device_create_sysfs() Constructor
 *
790 791 792 793 794 795
 * accept a created edac_device control structure
 * and 'export' it to sysfs. The 'main' kobj should already have been
 * created. 'instance' and 'block' kobjects should be registered
 * along with any 'block' attributes from the low driver. In addition,
 * the main attributes (if any) are connected to the main kobject of
 * the control structure.
796 797 798 799 800 801 802 803
 *
 * Return:
 *	0	Success
 *	!0	Failure
 */
int edac_device_create_sysfs(struct edac_device_ctl_info *edac_dev)
{
	int err;
804
	struct kobject *edac_kobj = &edac_dev->kobj;
805

806
	edac_dbg(0, "idx=%d\n", edac_dev->dev_idx);
807

808 809 810
	/*  go create any main attributes callers wants */
	err = edac_device_add_main_sysfs_attributes(edac_dev);
	if (err) {
811
		edac_dbg(0, "failed to add sysfs attribs\n");
812
		goto err_out;
813 814
	}

815 816 817 818
	/* create a symlink from the edac device
	 * to the platform 'device' being used for this
	 */
	err = sysfs_create_link(edac_kobj,
819
				&edac_dev->dev->kobj, EDAC_DEVICE_SYMLINK);
820
	if (err) {
821
		edac_dbg(0, "sysfs_create_link() returned err= %d\n", err);
822
		goto err_remove_main_attribs;
823 824
	}

825 826 827 828
	/* Create the first level instance directories
	 * In turn, the nested blocks beneath the instances will
	 * be registered as well
	 */
829
	err = edac_device_create_instances(edac_dev);
830
	if (err) {
831 832
		edac_dbg(0, "edac_device_create_instances() returned err= %d\n",
			 err);
833
		goto err_remove_link;
834 835 836
	}


837
	edac_dbg(4, "create-instances done, idx=%d\n", edac_dev->dev_idx);
838 839 840 841

	return 0;

	/* Error unwind stack */
842 843 844
err_remove_link:
	/* remove the sym link */
	sysfs_remove_link(&edac_dev->kobj, EDAC_DEVICE_SYMLINK);
845

846 847
err_remove_main_attribs:
	edac_device_remove_main_sysfs_attributes(edac_dev);
848

849
err_out:
850 851 852 853 854 855
	return err;
}

/*
 * edac_device_remove_sysfs() destructor
 *
856
 * given an edac_device struct, tear down the kobject resources
857 858 859
 */
void edac_device_remove_sysfs(struct edac_device_ctl_info *edac_dev)
{
860
	edac_dbg(0, "\n");
861

862 863
	/* remove any main attributes for this device */
	edac_device_remove_main_sysfs_attributes(edac_dev);
864

865
	/* remove the device sym link */
866 867
	sysfs_remove_link(&edac_dev->kobj, EDAC_DEVICE_SYMLINK);

868 869
	/* walk the instance/block kobject tree, deconstructing it */
	edac_device_delete_instances(edac_dev);
870
}