Commit e0e53db6 authored by K.Prasad's avatar K.Prasad Committed by Frederic Weisbecker

x86/hw-breakpoints: Optimize return code from notifier chain in hw_breakpoint_handler

Processing of debug exceptions in do_debug() can stop if it
originated from a hw-breakpoint exception by returning NOTIFY_STOP
in most cases.

But for certain cases such as:

a) user-space breakpoints with pending SIGTRAP signal delivery (as
in the case of ptrace induced breakpoints).

b) exceptions due to other causes than breakpoints

We will continue to process the exception by returning NOTIFY_DONE.
Signed-off-by: default avatarK.Prasad <>
Cc: Ingo Molnar <>
Cc: Roland McGrath <>
Cc: Alan Stern <>
Cc: Jan Kiszka <>
LKML-Reference: <>
Signed-off-by: default avatarFrederic Weisbecker <>
parent 40f9249a
......@@ -502,8 +502,6 @@ static int __kprobes hw_breakpoint_handler(struct die_args *args)
bp = per_cpu(bp_per_reg[i], cpu);
if (bp)
* Reset the 'i'th TRAP bit in dr6 to denote completion of
* exception handling
......@@ -522,7 +520,13 @@ static int __kprobes hw_breakpoint_handler(struct die_args *args)
if (dr6 & (~DR_TRAP_BITS))
* Further processing in do_debug() is needed for a) user-space
* breakpoints (to generate signals) and b) when the system has
* taken exception due to multiple causes
if ((current->thread.debugreg6 & DR_TRAP_BITS) ||
(dr6 & (~DR_TRAP_BITS)))
set_debugreg(dr7, 7);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment